Skip to content

Commit e5ba847

Browse files
committed
use $in_d variable
1 parent 7a645ae commit e5ba847

File tree

4 files changed

+14
-24
lines changed

4 files changed

+14
-24
lines changed

jscomp/bsb/bsb_ninja_gen.ml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -204,6 +204,7 @@ let output_ninja_and_namespace_map
204204
~has_pp:(pp_file <> None)
205205
~has_builtin:(built_in_dependency <> None)
206206
~reason_react_jsx
207+
~package_specs
207208
~digest
208209
generators in
209210
emit_bsc_lib_includes bs_dependencies source_dirs.lib external_includes namespace oc;

jscomp/bsb/bsb_ninja_rule.ml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,7 @@ let make_custom_rules
121121
~(reason_react_jsx : Bsb_config_types.reason_react_jsx option)
122122
~(digest : string)
123123
~(refmt : string option) (* set refmt path when needed *)
124+
~(package_specs: Bsb_package_specs.t)
124125
(custom_rules : command Map_string.t) :
125126
builtin =
126127
(** FIXME: We don't need set [-o ${out}] when building ast
@@ -133,6 +134,7 @@ let make_custom_rules
133134
Ext_buffer.clear buf;
134135
Ext_buffer.add_string buf "$bsc";
135136
Ext_buffer.add_ninja_prefix_var buf Bsb_ninja_global_vars.g_pkg_flg;
137+
Ext_buffer.add_string buf (Bsb_package_specs.package_flag_of_package_specs package_specs "$in_d");
136138
if read_cmi = `yes then
137139
Ext_buffer.add_string buf " -bs-read-cmi";
138140
if is_dev then

jscomp/bsb/bsb_ninja_rule.mli

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ val make_custom_rules :
7777
reason_react_jsx : Bsb_config_types.reason_react_jsx option ->
7878
digest:string ->
7979
refmt:string option ->
80+
package_specs:Bsb_package_specs.t ->
8081
command Map_string.t ->
8182
builtin
8283

lib/4.06.1/bsb.ml

Lines changed: 10 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -13048,6 +13048,7 @@ val make_custom_rules :
1304813048
reason_react_jsx : Bsb_config_types.reason_react_jsx option ->
1304913049
digest:string ->
1305013050
refmt:string option ->
13051+
package_specs:Bsb_package_specs.t ->
1305113052
command Map_string.t ->
1305213053
builtin
1305313054

@@ -13177,6 +13178,7 @@ let make_custom_rules
1317713178
~(reason_react_jsx : Bsb_config_types.reason_react_jsx option)
1317813179
~(digest : string)
1317913180
~(refmt : string option) (* set refmt path when needed *)
13181+
~(package_specs: Bsb_package_specs.t)
1318013182
(custom_rules : command Map_string.t) :
1318113183
builtin =
1318213184
(** FIXME: We don't need set [-o ${out}] when building ast
@@ -13189,6 +13191,7 @@ let make_custom_rules
1318913191
Ext_buffer.clear buf;
1319013192
Ext_buffer.add_string buf "$bsc";
1319113193
Ext_buffer.add_ninja_prefix_var buf Bsb_ninja_global_vars.g_pkg_flg;
13194+
Ext_buffer.add_string buf (Bsb_package_specs.package_flag_of_package_specs package_specs "$in_d");
1319213195
if read_cmi = `yes then
1319313196
Ext_buffer.add_string buf " -bs-read-cmi";
1319413197
if is_dev then
@@ -13694,20 +13697,7 @@ let handle_generators oc
1369413697
)
1369513698

1369613699

13697-
let make_common_shadows
13698-
package_specs
13699-
dirname
13700-
: Bsb_ninja_targets.shadow list
13701-
=
13702-
13703-
[{ key = Bsb_ninja_global_vars.g_pkg_flg;
13704-
op =
13705-
Append
13706-
(Bsb_package_specs.package_flag_of_package_specs
13707-
package_specs dirname
13708-
)
13709-
}]
13710-
13700+
1371113701

1371213702
type suffixes = {
1371313703
impl : string;
@@ -13765,10 +13755,6 @@ let emit_module_build
1376513755
let output_cmj = output_filename_sans_extension ^ Literals.suffix_cmj in
1376613756
let output_js =
1376713757
Bsb_package_specs.get_list_of_output_js package_specs output_filename_sans_extension in
13768-
let common_shadows =
13769-
make_common_shadows package_specs
13770-
(Filename.dirname output_cmi)
13771-
in
1377213758

1377313759
Bsb_ninja_targets.output_build oc
1377413760
~outputs:[output_mlast]
@@ -13791,20 +13777,19 @@ let emit_module_build
1379113777
;
1379213778
Bsb_ninja_targets.output_build oc
1379313779
~outputs:[output_cmi]
13794-
~shadows:common_shadows
1379513780
~order_only_deps:[output_d]
1379613781
~inputs:[output_mliast]
1379713782
~rule:(if is_dev then rules.mi_dev else rules.mi)
1379813783
;
1379913784
end;
1380013785

13801-
let shadows =
13786+
let shadows : Bsb_ninja_targets.shadow list =
1380213787
match js_post_build_cmd with
13803-
| None -> common_shadows
13788+
| None -> []
1380413789
| Some cmd ->
13805-
{key = Bsb_ninja_global_vars.postbuild;
13806-
op = Overwrite ("&& " ^ cmd ^ Ext_string.single_space ^ String.concat Ext_string.single_space output_js)}
13807-
:: common_shadows
13790+
[{key = Bsb_ninja_global_vars.postbuild;
13791+
op = Overwrite ("&& " ^ cmd ^ Ext_string.single_space ^ String.concat Ext_string.single_space output_js)}]
13792+
1380813793
in
1380913794
let rule =
1381013795
if has_intf_file then
@@ -14111,6 +14096,7 @@ let output_ninja_and_namespace_map
1411114096
~has_pp:(pp_file <> None)
1411214097
~has_builtin:(built_in_dependency <> None)
1411314098
~reason_react_jsx
14099+
~package_specs
1411414100
~digest
1411514101
generators in
1411614102
emit_bsc_lib_includes bs_dependencies source_dirs.lib external_includes namespace oc;

0 commit comments

Comments
 (0)