Avoid temporary list creation in typeDefDef

retronym · retronym · commit b955c4f17deb · 2019-02-20T13:22:03.000+10:00
diff --git a/src/compiler/scala/tools/nsc/typechecker/Typers.scala b/src/compiler/scala/tools/nsc/typechecker/Typers.scala
@@ -2351,10 +2351,9 @@ trait Typers extends Adaptations with Tags with TypersTracking with PatternTyper
           StarWithDefaultError(meth)
 
         if (!isPastTyper) {
-          val allParams = meth.paramss.flatten
-          for (p <- allParams) {
+          mforeach(meth.paramss) { p =>
             for (n <- p.deprecatedParamName) {
-              if (allParams.exists(p1 => p != p1 && (p1.name == n || p1.deprecatedParamName.exists(_ == n))))
+              if (mexists(meth.paramss)(p1 => p != p1 && (p1.name == n || p1.deprecatedParamName.exists(_ == n))))
                 DeprecatedParamNameError(p, n)
             }
           }

Original file line number	Diff line number	Diff line change
`@@ -2351,10 +2351,9 @@ trait Typers extends Adaptations with Tags with TypersTracking with PatternTyper`
`2351`	`2351`	`StarWithDefaultError(meth)`
`2352`	`2352`
`2353`	`2353`	`if (!isPastTyper) {`
`2354`		`- val allParams = meth.paramss.flatten`
`2355`		`- for (p <- allParams) {`
	`2354`	`+ mforeach(meth.paramss) { p =>`
`2356`	`2355`	`for (n <- p.deprecatedParamName) {`
`2357`		`- if (allParams.exists(p1 => p != p1 && (p1.name == n \|\| p1.deprecatedParamName.exists(_ == n))))`
	`2356`	`+ if (mexists(meth.paramss)(p1 => p != p1 && (p1.name == n \|\| p1.deprecatedParamName.exists(_ == n))))`
`2358`	`2357`	`DeprecatedParamNameError(p, n)`
`2359`	`2358`	`}`
`2360`	`2359`	`}`