Skip to content

Commit 5581667

Browse files
committed
Observable shared specs now called from IVar shared specs.
1 parent deffc99 commit 5581667

File tree

4 files changed

+12
-17
lines changed

4 files changed

+12
-17
lines changed

spec/concurrent/future_spec.rb

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
require_relative 'ivar_shared'
2-
require_relative 'observable_shared'
32
require_relative 'thread_arguments_shared'
43

54
module Concurrent
@@ -47,6 +46,11 @@ def execute_dereferenceable(subject)
4746
subject.execute
4847
sleep(0.1)
4948
end
49+
50+
def trigger_observable(observable)
51+
observable.execute
52+
sleep(0.1)
53+
end
5054
end
5155

5256
it_should_behave_like :thread_arguments do
@@ -60,16 +64,6 @@ def get_ivar_from_args(opts)
6064
end
6165
end
6266

63-
it_should_behave_like :observable do
64-
65-
subject{ Future.new{ nil } }
66-
67-
def trigger_observable(observable)
68-
observable.execute
69-
sleep(0.1)
70-
end
71-
end
72-
7367
context '#initialize' do
7468

7569
let(:executor) { ImmediateExecutor.new }

spec/concurrent/ivar_shared.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
11
require_relative 'dereferenceable_shared'
22
require_relative 'obligation_shared'
3+
require_relative 'observable_shared'
34

45
shared_examples :ivar do
56

67
it_should_behave_like :obligation
78
it_should_behave_like :dereferenceable
9+
it_should_behave_like :observable
810

911
context 'initialization' do
1012

spec/concurrent/ivar_spec.rb

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
require_relative 'ivar_shared'
2-
require_relative 'observable_shared'
32

43
module Concurrent
54

@@ -43,11 +42,6 @@ def dereferenceable_observable(opts = {})
4342
def execute_dereferenceable(subject)
4443
subject.set('value')
4544
end
46-
end
47-
48-
it_should_behave_like :observable do
49-
50-
subject{ IVar.new }
5145

5246
def trigger_observable(observable)
5347
observable.set('value')

spec/concurrent/promise_spec.rb

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,11 @@ def execute_dereferenceable(subject)
4141
subject.execute
4242
sleep(0.1)
4343
end
44+
45+
def trigger_observable(observable)
46+
observable.execute
47+
sleep(0.1)
48+
end
4449
end
4550

4651
it_should_behave_like :thread_arguments do

0 commit comments

Comments
 (0)