Remove deprecated status method

Author: pitr-ch

lib/concurrent/executor/java_thread_pool_executor.rb

@@ -149,15 +149,6 @@ def remaining_capacity
         @max_queue == 0 ? -1 : @executor.getQueue.remainingCapacity
       end
 
-      # This method is deprecated and will be removed soon.
-      # This method is supost to return the threads status, but Java API doesn't
-      # provide a way to get the thread status. So we return an empty Array instead.
-      def status
-        warn '[DEPRECATED] `status` is deprecated and will be removed soon.'
-        warn "Calls to `status` return an empty Array. Java ThreadPoolExecutor does not provide thread's status."
-        []
-      end
-
       # Is the thread pool running?
       #
       # @return [Boolean] `true` when running, `false` when shutting down or shutdown

lib/concurrent/executor/ruby_thread_pool_executor.rb

@@ -89,6 +89,7 @@ def initialize(opts = {})
       @pool                 = [] # all workers
       @ready                = [] # used as a stash (most idle worker is at the start)
       @queue                = [] # used as queue
+      # @ready or @queue is empty at all times
       @scheduled_task_count = 0
       @completed_task_count = 0
       @largest_length       = 0
@@ -201,6 +202,7 @@ def ns_kill_execution
     # tries to assign task to a worker, tries to get one from @ready or to create new one
     # @return [true, false] if task is assigned to a worker
     def ns_assign_worker(*args, &task)
+      # keep growing if the pool is not at the minimum yet
       worker = (@ready.pop if @pool.size >= @min_length) || ns_add_busy_worker
       if worker
         worker << [task, args]

spec/concurrent/executor/cached_thread_pool_shared.rb

@@ -95,15 +95,6 @@
     end
   end
 
-  context '#status' do
-
-    it 'returns an array' do
-      skip 'not added' unless subject.respond_to? :status
-      allow(subject).to receive(:warn)
-      expect(subject.status).to be_kind_of(Array)
-    end
-  end
-
   context '#idletime' do
 
     subject{ described_class.new(idletime: 42) }

spec/concurrent/executor/fixed_thread_pool_shared.rb

@@ -145,16 +145,6 @@
     end
   end
 
-  context '#status' do
-
-    it 'returns an array' do
-      skip 'not added' unless subject.respond_to? :status
-      allow(subject).to receive(:warn)
-      expect(subject.status).to be_kind_of(Array)
-    end
-  end
-
-
   context '#kill' do
 
     it 'attempts to kill all in-progress tasks' do