Skip to content

Update embedded-hal to 1.0.0-rc.1 #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

LehMaxence
Copy link
Contributor

I thought the crate could be bumped to 1.0.0-rc.1 as well. What do you think?

@LehMaxence LehMaxence requested a review from a team as a code owner September 22, 2023 20:34
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Could you rebase this to master to incorporate #98 ?

CHANGELOG.md Outdated
Comment on lines 10 to 11
## [v1.0.0-rc.1] - 2023-09-06

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## [v1.0.0-rc.1] - 2023-09-06

Let's keep the release separate. In any case we cannot release a version 1.0 while we have 0.x dependencies.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, should I revert the crate version too then?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please.

@LehMaxence LehMaxence force-pushed the update-hal-to-rc branch 2 times, most recently from fa928a3 to af12f85 Compare September 26, 2023 13:49
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work!

@eldruin eldruin added this pull request to the merge queue Sep 27, 2023
Merged via the queue into rust-embedded:master with commit 27daf71 Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants