Skip to content

Commit c537c15

Browse files
committed
Auto merge of #144238 - jhpratt:rollup-xb8aida, r=jhpratt
Rollup of 8 pull requests Successful merges: - rust-lang/rust#144144 (tests: Skip supported-crate-types test on musl hosts) - rust-lang/rust#144159 (opt-dist: change build_dir field to be an actual build dir) - rust-lang/rust#144162 (Debug impls for DropElaborators) - rust-lang/rust#144189 (Add non-regression test for rust-lang/rust#144168) - rust-lang/rust#144216 (Don't consider unstable fields always-inhabited) - rust-lang/rust#144229 (Miri subtree update) - rust-lang/rust#144230 (Option::as_slice: fix comment) - rust-lang/rust#144235 (Fix run-make tests on musl hosts) r? `@ghost` `@rustbot` modify labels: rollup
2 parents 522502d + 336e37e commit c537c15

34 files changed

+1349
-684
lines changed

CONTRIBUTING.md

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,16 +13,20 @@ for a list of Miri maintainers.
1313

1414
[Rust Zulip]: https://rust-lang.zulipchat.com
1515

16-
### Pull review process
16+
### PR review process
1717

1818
When you get a review, please take care of the requested changes in new commits. Do not amend
1919
existing commits. Generally avoid force-pushing. The only time you should force push is when there
2020
is a conflict with the master branch (in that case you should rebase across master, not merge), and
2121
all the way at the end of the review process when the reviewer tells you that the PR is done and you
22-
should squash the commits. If you are unsure how to use `git rebase` to squash commits, use `./miri
23-
squash` which automates the process but leaves little room for customization. (All this is to work
24-
around the fact that Github is quite bad at dealing with force pushes and does not support `git
25-
range-diff`. Maybe one day Github will be good at git and then life can become easier.)
22+
should squash the commits. (All this is to work around the fact that Github is quite bad at
23+
dealing with force pushes and does not support `git range-diff`.)
24+
25+
The recommended way to squash commits is to use `./miri squash`, which will make everything into a
26+
single commit. You will be asked for the commit message; please ensure it describes the entire PR.
27+
You can also use `git rebase` manually if you need more control (e.g. if there should be more than
28+
one commit at the end), but then please use `--keep-base` to ensure the PR remains based on the same
29+
upstream commit.
2630

2731
Most PRs bounce back and forth between the reviewer and the author several times, so it is good to
2832
keep track of who is expected to take the next step. We are using the `S-waiting-for-review` and
@@ -348,6 +352,7 @@ https. Add the following to your `.gitconfig`:
348352

349353
The following environment variables are relevant to `./miri`:
350354

355+
* `CARGO` sets the binary used to execute Cargo; if none is specified, defaults to `cargo`.
351356
* `MIRI_AUTO_OPS` indicates whether the automatic execution of rustfmt, clippy and toolchain setup
352357
(as controlled by the `./auto-*` files) should be skipped. If it is set to `no`, they are skipped.
353358
This is used to allow automated IDE actions to avoid the auto ops.

0 commit comments

Comments
 (0)