Auto merge of #46640 - tommyip:ui_tests, r=estebank

Enforce successful ui tests to have must-compile-successfully flag.

r? @nikomatsakis
cc @oli-obk

Fixes #46587

Author: bors

src/test/ui/check_match/issue-43253.rs

@@ -8,6 +8,8 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
+// must-compile-successfully
+
 #![feature(exclusive_range_pattern)]
 #![warn(unreachable_patterns)]
 

src/test/ui/check_match/issue-43253.stderr

@@ -1,24 +1,24 @@
 warning: unreachable pattern
-  --> $DIR/issue-43253.rs:37:9
+  --> $DIR/issue-43253.rs:39:9
    |
-37 |         9 => {},
+39 |         9 => {},
    |         ^
    |
 note: lint level defined here
-  --> $DIR/issue-43253.rs:12:9
+  --> $DIR/issue-43253.rs:14:9
    |
-12 | #![warn(unreachable_patterns)]
+14 | #![warn(unreachable_patterns)]
    |         ^^^^^^^^^^^^^^^^^^^^
 
 warning: unreachable pattern
-  --> $DIR/issue-43253.rs:43:9
+  --> $DIR/issue-43253.rs:45:9
    |
-43 |         8...9 => {},
+45 |         8...9 => {},
    |         ^^^^^
 
 warning: unreachable pattern
-  --> $DIR/issue-43253.rs:49:9
+  --> $DIR/issue-43253.rs:51:9
    |
-49 |         9...9 => {},
+51 |         9...9 => {},
    |         ^^^^^
 

src/test/ui/codemap_tests/unicode_3.rs

@@ -8,6 +8,8 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
+// must-compile-successfully
+
 fn main() {
     let s = "ZͨA͑ͦ͒͋ͤ͑̚L̄͑͋Ĝͨͥ̿͒̽̈́Oͥ͛ͭ!̏"; while true { break; }
     println!("{}", s);

src/test/ui/codemap_tests/unicode_3.stderr

@@ -1,7 +1,7 @@
 warning: denote infinite loops with `loop { ... }`
-  --> $DIR/unicode_3.rs:12:45
+  --> $DIR/unicode_3.rs:14:45
    |
-12 |     let s = "ZͨA͑ͦ͒͋ͤ͑̚L̄͑͋Ĝͨͥ̿͒̽̈́Oͥ͛ͭ!̏"; while true { break; }
+14 |     let s = "ZͨA͑ͦ͒͋ͤ͑̚L̄͑͋Ĝͨͥ̿͒̽̈́Oͥ͛ͭ!̏"; while true { break; }
    |                       ----------^^^^^^^^^^^
    |                       |
    |                       help: use `loop`

src/test/ui/explain.rs

@@ -9,3 +9,4 @@
 // except according to those terms.
 
 // compile-flags: --explain E0591
+// must-compile-successfully

src/test/ui/hello_world/main.rs

@@ -8,6 +8,8 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
+// must-compile-successfully
+
 // Test that compiling hello world succeeds with no output of any kind.
 
 fn main() {

src/test/ui/lint/command-line-lint-group-allow.rs

@@ -9,6 +9,7 @@
 // except according to those terms.
 
 // compile-flags: -A bad-style
+// must-compile-successfully
 
 fn main() {
     let _InappropriateCamelCasing = true;

src/test/ui/lint/command-line-lint-group-warn.rs

@@ -9,6 +9,7 @@
 // except according to those terms.
 
 // compile-flags: -W bad-style
+// must-compile-successfully
 
 fn main() {
     let _InappropriateCamelCasing = true;

src/test/ui/lint/command-line-lint-group-warn.stderr

@@ -1,7 +1,7 @@
 warning: variable `_InappropriateCamelCasing` should have a snake case name such as `_inappropriate_camel_casing`
-  --> $DIR/command-line-lint-group-warn.rs:14:9
+  --> $DIR/command-line-lint-group-warn.rs:15:9
    |
-14 |     let _InappropriateCamelCasing = true;
+15 |     let _InappropriateCamelCasing = true;
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `-W non-snake-case` implied by `-W bad-style`

src/test/ui/lint/not_found.rs

@@ -8,6 +8,8 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
+// must-compile-successfully
+
 // this tests the `unknown_lint` lint, especially the suggestions
 
 // the suggestion only appears if a lint with the lowercase name exists