-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Open
Labels
A-gitArea: `git`-related shenanigans (usually bootstrap related)Area: `git`-related shenanigans (usually bootstrap related)C-bugCategory: This is a bug.Category: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)needs-triageThis issue may need triage. Remove it if it has been sufficiently triaged.This issue may need triage. Remove it if it has been sufficiently triaged.
Description
I used submodule set-{url,branch}
to point src/llvm-project
against my own fork. Confusingly, bootstrap kept reverting to the original commit.
rust/src/bootstrap/src/core/config/config.rs
Lines 1422 to 1427 in bf5e6cc
let recorded = helpers::git(Some(&self.src)) | |
.run_in_dry_run() | |
.args(["ls-tree", "HEAD"]) | |
.arg(relative_path) | |
.run_capture_stdout(self) | |
.stdout(); |
recorded
uses the current commit staged in git. I'm not sure if this is a bug, but it was a bit surprising and unintuitive.
Metadata
Metadata
Assignees
Labels
A-gitArea: `git`-related shenanigans (usually bootstrap related)Area: `git`-related shenanigans (usually bootstrap related)C-bugCategory: This is a bug.Category: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)needs-triageThis issue may need triage. Remove it if it has been sufficiently triaged.This issue may need triage. Remove it if it has been sufficiently triaged.