-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Closed
Labels
A-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Description
As part of #53196, compile-fail
tests were migrated to ui
tests. As part of this PR, some tests remained as compile-fail
tests - due to an unresolvable issue (at the time) with the test that meant delaying migration meant more sense than holding up the PR (which needed rebased a lot). The main issues exhibited were:
- Extra lines of output on some platforms - there is currently no way to normalize a whole line out of the output, therefore tests that had extra lines on some platforms had to say as
compile-fail
tests.- This is the case with most of the tests updated in the later commits of Move
compile-fail
tests toui
#53196 that mention specific platforms.
- This is the case with most of the tests updated in the later commits of Move
- Non-deterministic ordering of error messages.
Metadata
Metadata
Assignees
Labels
A-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.