From 7ef7df08780bb5d7bb06bb6ec6c9c3fe31096b72 Mon Sep 17 00:00:00 2001 From: onur-ozkan Date: Sun, 30 Jun 2024 12:16:44 +0300 Subject: [PATCH] remove read-only restriction on `/checkout` Currently, we are setting read-only restrictions on `/checkout` path in containers, which conflicts with various bootstrap linking logic. This change removes this restriction. Signed-off-by: onur-ozkan --- src/ci/docker/run.sh | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/src/ci/docker/run.sh b/src/ci/docker/run.sh index a4c59b3067ead..b80173a8a29fa 100755 --- a/src/ci/docker/run.sh +++ b/src/ci/docker/run.sh @@ -225,14 +225,6 @@ else args="$args --env SCCACHE_DIR=/sccache --volume $HOME/.cache/sccache:/sccache" fi -# By default, container volumes are bound as read-only; therefore doing experimental work -# or debugging within the container environment (such as fetching submodules and -# building them) is not possible. Setting READ_ONLY_SRC to 0 enables this capability by -# binding the volumes in read-write mode. -if [ "$READ_ONLY_SRC" != "0" ]; then - SRC_MOUNT_OPTION=":ro" -fi - # Run containers as privileged as it should give them access to some more # syscalls such as ptrace and whatnot. In the upgrade to LLVM 5.0 it was # discovered that the leak sanitizer apparently needs these syscalls nowadays so @@ -267,7 +259,7 @@ if [ -f /.dockerenv ]; then docker cp . checkout:/checkout args="$args --volumes-from checkout" else - args="$args --volume $root_dir:/checkout$SRC_MOUNT_OPTION" + args="$args --volume $root_dir:/checkout" args="$args --volume $objdir:/checkout/obj" args="$args --volume $HOME/.cargo:/cargo" args="$args --volume /tmp/toolstate:/tmp/toolstate"