Skip to content

stabilize const_slice_reverse #143382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2025
Merged

stabilize const_slice_reverse #143382

merged 1 commit into from
Jul 19, 2025
+2 −1

Conversation

fee1-dead
Copy link
Member

@fee1-dead fee1-dead commented Jul 3, 2025 •
edited by rustbot
Loading

cc #135120, needs FCP.

@rustbot
Copy link
Collaborator

rustbot commented Jul 3, 2025

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 3, 2025
@cyrgani cyrgani added the needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. label Jul 3, 2025
@jhpratt
Copy link
Member

jhpratt commented Jul 3, 2025

r=me with completed FCP.

@jhpratt jhpratt added S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 3, 2025
@scottmcm
Copy link
Member

scottmcm commented Jul 9, 2025 •
edited
Loading

I think this is libs-api not libs?

My bad, the libs-api FCP is in the tracking issue.

@scottmcm scottmcm added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. and removed T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). labels Jul 9, 2025
@fee1-dead
Copy link
Member Author

FCP completed: #135120 (comment)

@bors r=jhpratt rollup

@bors
Copy link
Collaborator

bors commented Jul 18, 2025

📌 Commit 3c56c2e has been approved by jhpratt

It is now in the queue for this repository.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 18, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 18, 2025
@matthiaskrgr
Rollup merge of rust-lang#143382 - fee1-dead-contrib:push-trrymlzqmmo…
26ea00b 
…z, r=jhpratt

stabilize `const_slice_reverse`

cc rust-lang#135120, needs FCP.
This was referenced Jul 18, 2025
Closed
Merged
bors added a commit that referenced this pull request Jul 18, 2025
@bors
Auto merge of #144145 - matthiaskrgr:rollup-swc74s4, r=matthiaskrgr
6dfabf3 
Rollup of 9 pull requests

Successful merges:

 - #138554 (Distinguish delim kind to decide whether to emit unexpected closing delimiter)
 - #142673 (Show the offset, length and memory of uninit read errors)
 - #142693 (More robustly deal with relaxed bounds and improve their diagnostics)
 - #143382 (stabilize `const_slice_reverse`)
 - #143928 (opt-dist: make llvm builds optional)
 - #143961 (Correct which exploit mitigations are enabled by default)
 - #144050 (Fix encoding of link_section and no_mangle cross crate)
 - #144059 (Refactor `CrateLoader` into the `CStore`)
 - #144123 (Generalize `unsize` and `unsize_into` destinations)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Jul 19, 2025
@bors
Auto merge of #144145 - matthiaskrgr:rollup-swc74s4, r=matthiaskrgr
2ff5cce 
Rollup of 9 pull requests

Successful merges:

 - #138554 (Distinguish delim kind to decide whether to emit unexpected closing delimiter)
 - #142673 (Show the offset, length and memory of uninit read errors)
 - #142693 (More robustly deal with relaxed bounds and improve their diagnostics)
 - #143382 (stabilize `const_slice_reverse`)
 - #143928 (opt-dist: make llvm builds optional)
 - #143961 (Correct which exploit mitigations are enabled by default)
 - #144050 (Fix encoding of link_section and no_mangle cross crate)
 - #144059 (Refactor `CrateLoader` into the `CStore`)
 - #144123 (Generalize `unsize` and `unsize_into` destinations)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Jul 19, 2025
@bors
Auto merge of #144145 - matthiaskrgr:rollup-swc74s4, r=matthiaskrgr
1079c5e 
Rollup of 9 pull requests

Successful merges:

 - #138554 (Distinguish delim kind to decide whether to emit unexpected closing delimiter)
 - #142673 (Show the offset, length and memory of uninit read errors)
 - #142693 (More robustly deal with relaxed bounds and improve their diagnostics)
 - #143382 (stabilize `const_slice_reverse`)
 - #143928 (opt-dist: make llvm builds optional)
 - #143961 (Correct which exploit mitigations are enabled by default)
 - #144050 (Fix encoding of link_section and no_mangle cross crate)
 - #144059 (Refactor `CrateLoader` into the `CStore`)
 - #144123 (Generalize `unsize` and `unsize_into` destinations)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 401aaf4 into rust-lang:master Jul 19, 2025
10 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 19, 2025
rust-timer added a commit that referenced this pull request Jul 19, 2025
@rust-timer
Unrolled build for #143382
942cb77 
Rollup merge of #143382 - fee1-dead-contrib:push-trrymlzqmmoz, r=jhpratt

stabilize `const_slice_reverse`

cc #135120, needs FCP.
@RalfJung RalfJung mentioned this pull request Jul 19, 2025
Closed
3 tasks
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Jul 20, 2025
@bors
Auto merge of #144145 - matthiaskrgr:rollup-swc74s4, r=matthiaskrgr
16007d4 
Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#138554 (Distinguish delim kind to decide whether to emit unexpected closing delimiter)
 - rust-lang/rust#142673 (Show the offset, length and memory of uninit read errors)
 - rust-lang/rust#142693 (More robustly deal with relaxed bounds and improve their diagnostics)
 - rust-lang/rust#143382 (stabilize `const_slice_reverse`)
 - rust-lang/rust#143928 (opt-dist: make llvm builds optional)
 - rust-lang/rust#143961 (Correct which exploit mitigations are enabled by default)
 - rust-lang/rust#144050 (Fix encoding of link_section and no_mangle cross crate)
 - rust-lang/rust#144059 (Refactor `CrateLoader` into the `CStore`)
 - rust-lang/rust#144123 (Generalize `unsize` and `unsize_into` destinations)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jhpratt jhpratt

Labels
needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.
6 participants
@fee1-dead @rustbot @jhpratt @scottmcm @bors @cyrgani