From 110906444acea3c78eb43c0cf831548439670845 Mon Sep 17 00:00:00 2001
From: Prateek Srivastava <f2prateek@gmail.com>
Date: Fri, 13 Apr 2018 11:52:27 -0700
Subject: [PATCH] Catch and guard against Integration errors

To be able to record client side metrics, we need to modify analytics.js-integration to start propagate errors to analytics.js-core (https://paper.dropbox.com/doc/Analytics.js-Metrics-SDD-1hAD90lqGS4aZxHAHYPu7#:h2=analytics.js-integration) so that analytics.js-core can record metrics.

Currently analytics.js-integration is responsible for guarding when an integration method throws an error. Before changing the behaviour in analytics.js-integration, we need to make sure analytics.js-core guards against errors in integrations.
---
 lib/analytics.js       | 6 +++++-
 test/analytics.test.js | 5 +++++
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/lib/analytics.js b/lib/analytics.js
index e1cbbbe4..3d9a36c0 100644
--- a/lib/analytics.js
+++ b/lib/analytics.js
@@ -615,7 +615,11 @@ Analytics.prototype._invoke = function(method, facade) {
     if (failedInitializations.indexOf(name) >= 0) {
       self.log('Skipping invokation of .%s method of %s integration. Integation failed to initialize properly.', method, name);
     } else {
-      integration.invoke.call(integration, method, facade);
+      try {
+        integration.invoke.call(integration, method, facade);
+      } catch (e) {
+        self.log('Error invoking .%s method of %s integration: %o', method, name, e);
+      }
     }
   }, this._integrations);
 
diff --git a/test/analytics.test.js b/test/analytics.test.js
index ba27d72d..2d490568 100644
--- a/test/analytics.test.js
+++ b/test/analytics.test.js
@@ -322,6 +322,11 @@ describe('Analytics', function() {
       assert(!Test.prototype.invoke.called);
     });
 
+    it('should not crash when invoking integration fails', function() {
+      Test.prototype.invoke = function() { throw new Error('Uh oh!'); };
+      analytics.track('Test Event');
+    });
+
     it('should support .integrations to disable / select integrations', function() {
       var opts = { integrations: { Test: false } };
       analytics.identify('123', {}, opts);