remove after dependency #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsneed
approved these changes
Nov 18, 2019
fathyb
reviewed
Nov 19, 2019
| return this._initialPageSkipped = true; | ||
| } | ||
|
|
||
| return page.apply(this, arguments); |
There was a problem hiding this comment.
Is there a need to store initialPageSkipped on the instance? It could be simplified to:
var page = this.page;
var initialPageSkipped = false;
this.page = function() {
if (this._assumesPageview && !initialPageSkipped) {
return initialPageSkipped = true;
}
return page.apply(this, arguments);
}There was a problem hiding this comment.
good point. fixed!
rpaul80
reviewed
Nov 19, 2019
lib/protos.js
Outdated
| if (this._assumesPageview) { | ||
| if (this._initialPageSkipped) return page.apply(this, arguments); | ||
|
|
||
| return this._initialPageSkipped = true; |
There was a problem hiding this comment.
similar to my question #123
what do we expect this method to return ? It's a bit confusing reading that line, because it appears that we're returning a boolean, but that doesn't appear to be the intention. If the method return null, it might be clearer if we just used two lines, one to set the var, the other to explicitly return.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For https://segment.atlassian.net/browse/LIB-1430
This PR removes the dependency on "after" which violated customer CSP with a new Function() call.