From dca45f865bd80b4233787dbd3d4aafddd54e70b2 Mon Sep 17 00:00:00 2001 From: rhall-twilio <103517471+rhall-twilio@users.noreply.github.com> Date: Wed, 8 Feb 2023 11:43:59 -0600 Subject: [PATCH 1/6] STRATCONN-1287 - Add support for DoubleClick Floodlight config in in Google Ads (GTag) (#730) * Google Ads (GTag): add support for doubleclick floodlight id * nit: add floodlightAccountId as an option to the initializer * bump package.json for google ads --- integrations/google-adwords-new/HISTORY.md | 6 +++++- integrations/google-adwords-new/lib/index.js | 5 +++++ integrations/google-adwords-new/package.json | 2 +- integrations/google-adwords-new/test/index.test.js | 12 ++++++++++++ 4 files changed, 23 insertions(+), 2 deletions(-) diff --git a/integrations/google-adwords-new/HISTORY.md b/integrations/google-adwords-new/HISTORY.md index 0810298b8..7bd3d456b 100644 --- a/integrations/google-adwords-new/HISTORY.md +++ b/integrations/google-adwords-new/HISTORY.md @@ -1,7 +1,11 @@ +1.3.0 / 2023-02-08 +================== + * Introduces a new setting `floodlightAccountId` to enable passing the DoubleClick Floodlight config ID to GTag's `config` to allow better synergy between these two products. + 1.2.0 / 2020-02-18 ================== - * Introduces a new setting `disableAdPersonalization` to disable collection of remarketing data for users who do not wish to view personalized ads. When this settiing is `true`, Segment will set `allow_ad_personalization_signals` to false. + * Introduces a new setting `disableAdPersonalization` to disable collection of remarketing data for users who do not wish to view personalized ads. When this setting is `true`, Segment will set `allow_ad_personalization_signals` to false. 1.1.1 / 2019-12-09 ================== diff --git a/integrations/google-adwords-new/lib/index.js b/integrations/google-adwords-new/lib/index.js index 19e77b11e..39317b99f 100644 --- a/integrations/google-adwords-new/lib/index.js +++ b/integrations/google-adwords-new/lib/index.js @@ -22,6 +22,7 @@ var GoogleAdWordsNew = (module.exports = integration('Google AdWords New') .option('pageLoadConversions', []) .option('defaultPageConversion', '') .option('disableAdPersonalization', false) + .option('floodlightAccountId', '') // The ID in this line (i.e. the gtag.js ID) does not determine which account(s) will receive data from the tag; rather, it is used to uniquely identify your global site tag. Which account(s) receive data from the tag is determined by calling the config command (and by using the send_to parameter on an event). For instance, if you use Google Analytics, you may already have the gtag.js global site tag installed on your site. In that case, the gtag.js ID may be that of the Google Analytics property where you first obtained the snippet. .tag( '' + '' ) // Sentry.Integrations.RewriteFrames plugin: https://docs.sentry.io/platforms/javascript/#rewriteframes .tag( 'plugin', - '' + '' )); /** @@ -53,8 +51,8 @@ Sentry.prototype.initialize = function() { environment: this.options.environment, release: customRelease || this.options.release, serverName: this.options.serverName, - whitelistUrls: this.options.whitelistUrls, - blacklistUrls: this.options.ignoreUrls, + allowUrls: this.options.allowUrls, + denyUrls: this.options.ignoreUrls, // ignoreErrors still exists, but is not documented on Sentry's website // https://github.com/getsentry/sentry-javascript/blob/master/packages/core/src/integrations/inboundfilters.ts#L12 ignoreErrors: this.options.ignoreErrors, diff --git a/tester/src/utils.js b/tester/src/utils.js index 33bd58d8a..018cf0163 100644 --- a/tester/src/utils.js +++ b/tester/src/utils.js @@ -1,7 +1,7 @@ import { AnalyticsBrowser } from '@segment/analytics-next'; export async function getSettings(wk) { - let data = await fetch(`https://cdn.segment.com/v1/projects/${wk}/settings`); + let data = await fetch(`https://cdn.segment.build/v1/projects/${wk}/settings`); data = await data.json(); return cleanSettings(data); } From d8dead198c4d83938b088d7349115e600997267d Mon Sep 17 00:00:00 2001 From: Ankit Gupta Date: Tue, 28 Mar 2023 05:18:05 +0530 Subject: [PATCH 5/6] HGI-404 change cdn settings --- tester/src/utils.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tester/src/utils.js b/tester/src/utils.js index 018cf0163..33bd58d8a 100644 --- a/tester/src/utils.js +++ b/tester/src/utils.js @@ -1,7 +1,7 @@ import { AnalyticsBrowser } from '@segment/analytics-next'; export async function getSettings(wk) { - let data = await fetch(`https://cdn.segment.build/v1/projects/${wk}/settings`); + let data = await fetch(`https://cdn.segment.com/v1/projects/${wk}/settings`); data = await data.json(); return cleanSettings(data); } From 40588acd763220056966fa3149a228a1059140e8 Mon Sep 17 00:00:00 2001 From: Ankit Gupta Date: Thu, 30 Mar 2023 19:32:00 +0530 Subject: [PATCH 6/6] Package version change for sentry --- integrations/sentry/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/integrations/sentry/package.json b/integrations/sentry/package.json index 33b4e2dc1..18fdfdb3a 100644 --- a/integrations/sentry/package.json +++ b/integrations/sentry/package.json @@ -1,7 +1,7 @@ { "name": "@segment/analytics.js-integration-sentry", "description": "The Sentry analytics.js integration.", - "version": "3.0.1", + "version": "3.0.2", "keywords": [ "analytics.js", "analytics.js-integration",