change choco to release with github artifacts and dotnet deployer addon (#6383)

* change choco to release with github artifacts and dotnet deployer addon

* actually, break this step up into build + publish steps

Author: hughesjj

.gitlab-ci.yml

@@ -32,7 +32,7 @@ stages:
   - release
   - docker-manifest-release
   - xray-scan
-  - github-release
+  - publish-release
 
 include:
   - project: 'prodsec/scp-scanning/gitlab-checkmarx'
@@ -1563,7 +1563,7 @@ release-installers:
   before_script:
     - cp -f dist/signed/install.ps1 packaging/installer/install.ps1
 
-choco-release:
+nupkg-release:
   extends: .trigger-filter
   stage: release
   dependencies:
@@ -1582,14 +1582,33 @@ choco-release:
       }
       .\packaging\choco\make.ps1 build_choco -Version $version -BuildDir .\dist\signed
     - Test-Path .\dist\signed\splunk-otel-collector.${version}.nupkg
+  artifacts:
+    paths:
+      - dist/signed/*.nupkg
+
+choco-release:
+  extends: .trigger-filter
+  stage: publish-release
+  dependencies:
+    - nupkg-release
+  tags:
+    - splunk-otel-collector-windows
+  script:
+    - |
+      $ErrorActionPreference = 'Stop'
+      Set-PSDebug -Trace 1
+      $msi_file_name = Resolve-Path .\dist\signed\splunk-otel-collector*.msi | Split-Path -leaf
+      if ($msi_file_name -match '(\d+\.\d+\.\d+)(\.\d+)?') {
+        $version = $matches[0]
+      } else {
+        throw "Failed to get version from $msi_file_name"
+      }
+    - Test-Path .\dist\signed\splunk-otel-collector.${version}.nupkg
     - |
       # Only push the choco package for stable release tags
       if ($env:CI_COMMIT_TAG -match '^v\d+\.\d+\.\d+$') {
         choco push -k $env:CHOCO_TOKEN .\dist\signed\splunk-otel-collector.${version}.nupkg
       }
-  artifacts:
-    paths:
-      - dist/signed/*.nupkg
 
 push-multiarch-manifest:
   extends: .trigger-filter
@@ -1752,7 +1771,7 @@ github-release:
     - .trigger-filter
     - .go-cache
   tags: [large]
-  stage: github-release
+  stage: publish-release
   dependencies:
     - compile
     - otelcol-fips
@@ -1764,7 +1783,6 @@ github-release:
     - sign-msi
     - sign-tar
     - push-multiarch-manifest
-    - choco-release
     - sign-agent-bundles
   script:
     - mkdir -p dist/assets
@@ -1926,7 +1944,7 @@ dotnet-instrumentation-deployer-release:
     - .trigger-dotnet-instrumentation-deployer
     - .go-cache # Use this image since this job uses the ghr tool
   tags: [large]
-  stage: github-release
+  stage: publish-release
   dependencies:
     - pack-dotnet-instrumentation-deployer
   script: