Merge pull request #37 from skellock/welcome-to-lint-town

Lints hard and with a vengeance.

Author: skellock

package-lock.json

@@ -71,6 +71,9 @@
     "standard": "10.0.2",
     "ts-node": "3.3.0",
     "tslint": "5.5.0",
+    "tslint-eslint-rules": "4.1.1",
+    "tslint-react": "3.2.0",
+    "tslint-react-recommended": "1.0.15",
     "typescript": "2.4.2"
   },
   "electron-ava": {
@@ -110,6 +113,11 @@
     "pack": "electron-builder --dir",
     "postinstall": "electron-builder install-app-deps",
     "precommit": "lint-staged",
+    "lint": "npm-run-all lint:*",
+    "lint:ts": "tslint \"src/**/*.{ts,tsx}\"",
+    "lint:js": "standard",
+    "sanity": "npm-run-all check lint test",
+    "prepush": "npm-run-all sanity",
     "start": "node fuse",
     "test": "npm-run-all test:main test:renderer",
     "test:main": "electron-ava src/main/**/*.test.js",

package.json

@@ -19,16 +19,16 @@ export function createMainWindow(appPath: string) {
     titleBarStyle: 'hidden',
     autoHideMenuBar: true,
     backgroundColor: '#fff',
-    title: app.getName()
+    title: app.getName(),
   })
 
   // load entry html page in the renderer.
   window.loadURL(
     format({
       pathname: join(appPath, 'out/index.html'),
       protocol: 'file:',
-      slashes: true
-    })
+      slashes: true,
+    }),
   )
 
   // only appear once we've loaded

src/main/main-window/main-window.ts

@@ -2,28 +2,28 @@ import { createSharedMenuItems } from './shared-menu'
 import * as isDev from 'electron-is-dev'
 
 export function createLinuxMenu(
-  window: Electron.BrowserWindow
+  window: Electron.BrowserWindow,
 ): Electron.MenuItemConstructorOptions[] {
   const shared = createSharedMenuItems(window)
 
   const fileMenu: Electron.MenuItemConstructorOptions = {
     label: '&File',
-    submenu: [{ ...shared.quit, accelerator: 'Alt+F4' }]
+    submenu: [{ ...shared.quit, accelerator: 'Alt+F4' }],
   }
 
   const viewMenu: Electron.MenuItemConstructorOptions = {
     label: 'View',
     submenu: isDev
       ? [
           { ...shared.reload, accelerator: 'Ctrl+R' },
-          { ...shared.toggleDevTools, accelerator: 'Ctrl+Alt+I' }
-        ]
-      : [{ ...shared.fullScreen, accelerator: 'Ctrl+Alt+F' }]
+          { ...shared.toggleDevTools, accelerator: 'Ctrl+Alt+I' },
+      ]
+      : [{ ...shared.fullScreen, accelerator: 'Ctrl+Alt+F' }],
   }
 
   const helpMenu: Electron.MenuItemConstructorOptions = {
     label: 'Help',
-    submenu: [shared.visit]
+    submenu: [shared.visit],
   }
 
   return [fileMenu, viewMenu, helpMenu]

src/main/menu/linux-menu.ts

@@ -3,7 +3,7 @@ import { createSharedMenuItems } from './shared-menu'
 import * as isDev from 'electron-is-dev'
 
 export function createMacMenu(
-  window: Electron.BrowserWindow
+  window: Electron.BrowserWindow,
 ): Electron.MenuItemConstructorOptions[] {
   const shared = createSharedMenuItems(window)
   const name: string = app.getName()
@@ -17,23 +17,23 @@ export function createMacMenu(
       { label: 'Hide Others', accelerator: 'Command+Option+H', role: 'hideOtherApplications' },
       { label: 'Show All', role: 'unhideAllApplications' },
       { type: 'separator' },
-      { ...shared.quit, accelerator: 'Command+Q' }
-    ]
+      { ...shared.quit, accelerator: 'Command+Q' },
+    ],
   }
 
   const viewMenu: Electron.MenuItemConstructorOptions = {
     label: 'View',
     submenu: isDev
       ? [
           { ...shared.reload, accelerator: 'Command+R' },
-          { ...shared.toggleDevTools, accelerator: 'Alt+Command+I' }
-        ]
-      : [{ ...shared.fullScreen, accelerator: 'Ctrl+Command+F' }]
+          { ...shared.toggleDevTools, accelerator: 'Alt+Command+I' },
+      ]
+      : [{ ...shared.fullScreen, accelerator: 'Ctrl+Command+F' }],
   }
 
   const helpMenu: Electron.MenuItemConstructorOptions = {
     label: 'Help',
-    submenu: [shared.visit]
+    submenu: [shared.visit],
   }
 
   return [appMenu, viewMenu, helpMenu]

src/main/menu/macos-menu.ts

@@ -5,14 +5,14 @@ export function createSharedMenuItems(window: Electron.BrowserWindow) {
     label: 'Visit on Github',
     click() {
       shell.openExternal('https://github.com/skellock/electron-starter')
-    }
+    },
   }
 
   const reload: Electron.MenuItemConstructorOptions = {
     label: 'Reload',
     click() {
       window.webContents.reload()
-    }
+    },
   }
 
   const quit: Electron.MenuItemConstructorOptions = { label: 'Quit', role: 'quit' }
@@ -21,21 +21,21 @@ export function createSharedMenuItems(window: Electron.BrowserWindow) {
     label: 'Toggle Developer Tools',
     click() {
       window.webContents.toggleDevTools()
-    }
+    },
   }
 
   const fullScreen: Electron.MenuItemConstructorOptions = {
     label: 'Toggle Full Screen',
     click() {
       window.setFullScreen(!window.isFullScreen())
-    }
+    },
   }
 
   return {
     visit,
     reload,
     quit,
     toggleDevTools,
-    fullScreen
+    fullScreen,
   }
 }

src/main/menu/shared-menu.ts

@@ -2,28 +2,28 @@ import { createSharedMenuItems } from './shared-menu'
 import * as isDev from 'electron-is-dev'
 
 export function createWindowsMenu(
-  window: Electron.BrowserWindow
+  window: Electron.BrowserWindow,
 ): Electron.MenuItemConstructorOptions[] {
   const shared = createSharedMenuItems(window)
 
   const fileMenu: Electron.MenuItemConstructorOptions = {
     label: '&File',
-    submenu: [{ ...shared.quit, accelerator: 'Alt+F4' }]
+    submenu: [{ ...shared.quit, accelerator: 'Alt+F4' }],
   }
 
   const viewMenu: Electron.MenuItemConstructorOptions = {
     label: 'View',
     submenu: isDev
       ? [
           { ...shared.reload, accelerator: 'Ctrl+R' },
-          { ...shared.toggleDevTools, accelerator: 'Ctrl+Alt+I' }
-        ]
-      : [{ ...shared.fullScreen, accelerator: 'Ctrl+Alt+F' }]
+          { ...shared.toggleDevTools, accelerator: 'Ctrl+Alt+I' },
+      ]
+      : [{ ...shared.fullScreen, accelerator: 'Ctrl+Alt+F' }],
   }
 
   const helpMenu: Electron.MenuItemConstructorOptions = {
     label: 'Help',
-    submenu: [shared.visit]
+    submenu: [shared.visit],
   }
 
   return [fileMenu, viewMenu, helpMenu]

src/main/menu/windows-menu.ts

@@ -34,8 +34,10 @@ Heads up: dev-app-update.yml is in the .gitignore file.
  * @param app The electron app.
  */
 export function createUpdater(app: Electron.App): void {
-  // jet if we shoulldn't be here
-  if (!shouldCheck) return
+  // jet if we shouldn't be here
+  if (!shouldCheck) {
+    return
+  }
 
   // configure the autoUpdater's logger
   autoUpdater.logger = log

src/main/updater/updater.ts

@@ -6,7 +6,7 @@ import { Logo } from '../logo/logo'
 
 const TEXT_STYLE: CSSProperties = {
   paddingTop: spacing.medium,
-  paddingBottom: spacing.medium
+  paddingBottom: spacing.medium,
 }
 
 export class DogTab extends React.Component<{}, {}> {

src/renderer/features/example-using-tabs/dog-tab/dog-tab.tsx

@@ -9,7 +9,7 @@ const ROOT_STYLE: CSSProperties = {
   textAlign: 'center',
   paddingTop: spacing.verySmall,
   backgroundColor: colors.headerBg,
-  fontSize: fontSizes.small
+  fontSize: fontSizes.small,
 }
 
 const title = remote.require('../package.json').name