feat: improve information in the user-agent param #427
+53
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkedziak-splunk
previously approved these changes
Mar 4, 2025
artemrys
reviewed
Mar 4, 2025
kkedziak-splunk
approved these changes
Mar 4, 2025
|
I'd like to get this one released and it seems like a very small but |
| search_results = search(session_key, test_url) | ||
| if len(search_results) > 0: | ||
| break | ||
| sleep(0.5) |
There was a problem hiding this comment.
Do we require this sleep as it is already present in "search" import?
There was a problem hiding this comment.
you are right, this sleep here is not that relevant but since we break after result is found I think we can keep it.
sure, lets release it :) |
sgoral-splunk
changed the title
artemrys
approved these changes
Mar 6, 2025
|
🎉 This PR is included in version 6.2.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 6.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: ADDON-76041
PR Type
What kind of change does this PR introduce?
Summary
Changes
Changed "User-Agent" header parameter from
Curltosolnlib/<version> rest-client <os platform>User experience
The user will see more detailed "User-Agent" information in the logs regarding requests made using the rest client.
Checklist
If an item doesn't apply to your changes, leave it unchecked.