Skip to content

Commit 489ffcf

Browse files
tha2015jgrandja
authored andcommitted
UserInfoTypeConverter is registered if client is registered
Fixes gh-4364
1 parent 6c0ecea commit 489ffcf

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

samples/boot/oauth2login/src/main/java/org/springframework/boot/autoconfigure/security/oauth2/client/ClientRegistrationAutoConfiguration.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,8 @@
4747
@ConditionalOnMissingBean(ClientRegistrationRepository.class)
4848
@AutoConfigureBefore(SecurityAutoConfiguration.class)
4949
public class ClientRegistrationAutoConfiguration {
50-
private static final String CLIENT_ID_PROPERTY = "client-id";
5150
private static final String CLIENTS_DEFAULTS_RESOURCE = "META-INF/oauth2-clients-defaults.yml";
51+
static final String CLIENT_ID_PROPERTY = "client-id";
5252
static final String CLIENT_PROPERTY_PREFIX = "security.oauth2.client";
5353

5454
@Configuration

samples/boot/oauth2login/src/main/java/org/springframework/boot/autoconfigure/security/oauth2/client/OAuth2LoginAutoConfiguration.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,7 @@
4040
import java.util.Set;
4141
import java.util.function.Function;
4242

43-
import static org.springframework.boot.autoconfigure.security.oauth2.client.ClientRegistrationAutoConfiguration.CLIENT_PROPERTY_PREFIX;
44-
import static org.springframework.boot.autoconfigure.security.oauth2.client.ClientRegistrationAutoConfiguration.resolveClientPropertyKeys;
43+
import static org.springframework.boot.autoconfigure.security.oauth2.client.ClientRegistrationAutoConfiguration.*;
4544

4645
/**
4746
* @author Joe Grandja
@@ -84,6 +83,9 @@ private void registerUserInfoTypeConverters(OAuth2LoginConfigurer<HttpSecurity>
8483
Set<String> clientPropertyKeys = resolveClientPropertyKeys(this.environment);
8584
for (String clientPropertyKey : clientPropertyKeys) {
8685
String fullClientPropertyKey = CLIENT_PROPERTY_PREFIX + "." + clientPropertyKey;
86+
if (!this.environment.containsProperty(fullClientPropertyKey + "." + CLIENT_ID_PROPERTY)) {
87+
continue;
88+
}
8789
String userInfoUriValue = this.environment.getProperty(fullClientPropertyKey + "." + USER_INFO_URI_PROPERTY);
8890
String userInfoConverterTypeValue = this.environment.getProperty(fullClientPropertyKey + "." + USER_INFO_CONVERTER_PROPERTY);
8991
if (userInfoUriValue != null && userInfoConverterTypeValue != null) {

0 commit comments

Comments
 (0)