gcPauses -> jvm.gc.pause, memory -> jvm.memory.used

Author: BoykoAlex

headless-services/spring-boot-language-server/src/main/java/org/springframework/ide/vscode/boot/java/livehover/v2/HttpActuatorConnection.java

@@ -80,7 +80,7 @@ public String getBeans() throws IOException {
 	@Override
 	public String getLiveMetrics(String metricName, String tags) throws IOException {
 		UriComponentsBuilder uriBuilder = UriComponentsBuilder.fromPath("/metrics/"+metricName);
-		if (tags != null) {
+		if (tags != null && !tags.isBlank()) {
 		    uriBuilder.queryParam("tag", tags);
 		}
 		String url = uriBuilder.encode().toUriString();

headless-services/spring-boot-language-server/src/main/java/org/springframework/ide/vscode/boot/java/livehover/v2/Measurements.java

@@ -1,16 +1,26 @@
+/*******************************************************************************
+ * Copyright (c) 2022 VMware, Inc.
+ * All rights reserved. This program and the accompanying materials
+ * are made available under the terms of the Eclipse Public License v1.0
+ * which accompanies this distribution, and is available at
+ * https://www.eclipse.org/legal/epl-v10.html
+ *
+ * Contributors:
+ *     VMware, Inc. - initial API and implementation
+ *******************************************************************************/
 package org.springframework.ide.vscode.boot.java.livehover.v2;
 
 public class Measurements {
 
 	private String statistic;
-	private Long value;
+	private Double value;
 
 	public String getStatistic() {
 		return statistic;
 	}
 
 
-	public Long getValue() {
+	public Double getValue() {
 		return value;
 	}
 

headless-services/spring-boot-language-server/src/main/java/org/springframework/ide/vscode/boot/java/livehover/v2/ProcessType.java

@@ -1,3 +1,13 @@
+/*******************************************************************************
+ * Copyright (c) 2022 VMware, Inc.
+ * All rights reserved. This program and the accompanying materials
+ * are made available under the terms of the Eclipse Public License v1.0
+ * which accompanies this distribution, and is available at
+ * https://www.eclipse.org/legal/epl-v10.html
+ *
+ * Contributors:
+ *     VMware, Inc. - initial API and implementation
+ *******************************************************************************/
 package org.springframework.ide.vscode.boot.java.livehover.v2;
 
 public enum ProcessType {

headless-services/spring-boot-language-server/src/main/java/org/springframework/ide/vscode/boot/java/livehover/v2/SpringProcessCommandHandler.java

@@ -301,11 +301,11 @@ private CompletableFuture<Object> handleLiveMetricsProcessRequest(ExecuteCommand
 		String metricName = getArgumentByKey(params, "metricName");
 		if (processKey != null) {
 			switch(metricName) {
-				case "gcPauses": {
+				case SpringProcessConnectorService.GC_PAUSES: {
 					SpringProcessGcPausesMetricsLiveData data = connectorService.getGcPausesMetricsLiveData(processKey);
 					return CompletableFuture.completedFuture(data.getGcPausesMetrics());
 				}
-				case "memory": {
+				case SpringProcessConnectorService.MEMORY: {
 					SpringProcessMemoryMetricsLiveData data = connectorService.getMemoryMetricsLiveData(processKey);
 					return CompletableFuture.completedFuture(data.getMemoryMetrics());
 				}

headless-services/spring-boot-language-server/src/main/java/org/springframework/ide/vscode/boot/java/livehover/v2/SpringProcessConnectorService.java

@@ -29,6 +29,10 @@
  */
 public class SpringProcessConnectorService {
 
+	private static final String METRICS = "metrics";
+	public static final String GC_PAUSES = "jvm.gc.pause";
+	public static final String MEMORY = "jvm.memory.used";
+
 	private static final Logger log = LoggerFactory.getLogger(SpringProcessConnectorService.class);
 
 	private final SpringProcessLiveDataProvider liveDataProvider;
@@ -171,8 +175,8 @@ private void scheduleConnect(ProgressTask progressTask, String processKey, Sprin
 				progressTask.progressDone();
 
 				refreshProcess(new SpringProcessParams(processKey, "", "", ""));
-				refreshProcess(new SpringProcessParams(processKey, "metrics", "memory", "area:heap"));
-				refreshProcess(new SpringProcessParams(processKey, "metrics", "gcPauses", ""));
+				refreshProcess(new SpringProcessParams(processKey, METRICS, MEMORY, "area:heap"));
+				refreshProcess(new SpringProcessParams(processKey, METRICS, GC_PAUSES, ""));
 			}
 			catch (Exception e) {
 				log.info("problem occured during process connect", e);
@@ -232,7 +236,7 @@ private void scheduleRefresh(ProgressTask progressTask, SpringProcessParams spri
 
 			try {
 				progressTask.progressEvent(progressMessage);
-				if(endpoint.equals("metrics") && metricName.equals("memory")) {
+				if(METRICS.equals(endpoint) && MEMORY.equals(metricName)) {
 					SpringProcessMemoryMetricsLiveData newMetricsLiveData = connector.refreshMemoryMetrics(this.liveDataProvider.getCurrent(processKey), metricName, springProcessParams.getTags());
 
 					if (newMetricsLiveData != null) {
@@ -243,7 +247,7 @@ private void scheduleRefresh(ProgressTask progressTask, SpringProcessParams spri
 						this.connectedSuccess.put(processKey, true);
 					}
 
-				} else if(endpoint.equals("metrics") && metricName.equals("gcPauses")) {
+				} else if(METRICS.equals(endpoint) && GC_PAUSES.equals(metricName)) {
 					SpringProcessGcPausesMetricsLiveData newMetricsLiveData = connector.refreshGcPausesMetrics(this.liveDataProvider.getCurrent(processKey), metricName, springProcessParams.getTags());
 
 					if (newMetricsLiveData != null) {