Skip to content

Fix concourse task schema #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2019
Merged

Fix concourse task schema #387

merged 1 commit into from
Nov 1, 2019

Conversation

z4ce
Copy link
Contributor

@z4ce z4ce commented Oct 31, 2019

Currently the language server throws an error like
"Expected string, got sequence" when you use yaml
as a default for a parameter in a task yaml.
See added test for an example that triggers the
behavior.

Currently the language server throws an error like
"Expected string, got sequence" when you use yaml
as a default for a parameter in a task yaml.
See added test for an example that triggers the
behavior.

Co-Authored-By: Thad Craft <[email protected]>
@martinlippert martinlippert added this to the 4.4.2.RELEASE milestone Nov 1, 2019
Copy link
Member

@kdvolder kdvolder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@spring-projects-issues
Copy link

(comment in Pivotal Tracker added by Kris De Volder:)

I've merged the PR and so marking this ticket as 'finished'. We'll can through the usual Deliver/Accept process after this (i.e. I will do a quick test from snapshot build, then click the deliver button, and someone else i.e. Martin can do another check before accepting :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants