Skip to content

[concourse] Add support for set-pipeline step #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

deepakmohanakrishnan07
Copy link

Concourse Language Server is used in multiple IDEs, SpringToolSuite, VS. Code, etc., to provide validation, content assist and documentation hovers for editing Concourse Pipeline and Task configuration files.

This PR includes changes to Concourse Language Server to provide the support for set-pipeline pipeline entity syntax highlighting, validation, and doc.

@kdvolder
Copy link
Member

Thanks for the quality PR. Tests and everything :-)

@kdvolder kdvolder merged commit 2f5993a into spring-projects:master May 19, 2020
@kdvolder
Copy link
Member

Started getting some test failures after merging the PR.

https://ci.spring.io/teams/tools/pipelines/sts4-master/jobs/build-consourse-vsix-snapshot/builds/1666

For example:

[ERROR] Failures: 
[ERROR]   ConcourseEditorTest.primaryStepCompletions:299->assertContextualCompletions:5965->assertContextualCompletions:5969->assertContextualCompletions:5982 expected:<...ome-job
  plan:
  - []task: <*>
----------...> but was:<...ome-job
  plan:
  - [set_pipeline: <*>
-------------------
jobs:
- name: some-job
  plan:
  - ]task: <*>
----------...>
[ERROR]   ConcourseEditorTest.primaryStepHovers:363 Not found: Fetches a resource
 in 

[ERROR]   ConcourseEditorTest.relaxedIndentContextMoreSpaces3:4161 expected:<...in_parallel
- put
- []task
- try
- aggrega...> but was:<...in_parallel
- put
- [set_pipeline
- ]task
- try
- aggrega...>
[ERROR]   ConcourseEditorTest.setPipelineStepHovers:409 Not found: The path to the pipeline's configuration file.

I'm reverting the merge until I have to time to look into it in detail.

@martinlippert martinlippert added this to the 4.6.2.RELEASE milestone May 20, 2020
kdvolder added a commit that referenced this pull request May 21, 2020
See #464

Problems found:

- issues with formatting of the test case examples. Spaces vs tabs
  issues and weird indentation of the examples causing problems
  for editor to parse examples.

- added 'set_pipeline' step caused some other tests fail
  because they should correctly expect this as a valid
  completion, but tests had not been updated to reflect
  that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants