Skip to content

Commit e6a0847

Browse files
committed
Wherever we use become_user set become: true, keeps the linter happy and maintains functionality
1 parent 6a698b2 commit e6a0847

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

ansible/roles/basic_users/tasks/main.yml

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,8 @@
7979
owner: "{{ item.name }}"
8080
group: "{{ item.name }}"
8181
mode: u=rwX,go=
82-
# become_user: "{{ item.name }}" # Commenting out as become_user does not imply become: true
82+
become: true
83+
become_user: "{{ item.name }}"
8384
loop: "{{ basic_users_users }}"
8485
loop_control:
8586
label: "{{ item.name }}"
@@ -95,7 +96,8 @@
9596
comment: "{{ item.ssh_key_comment | default(item.name) }}"
9697
vars:
9798
_ssh_key_type: "{{ item.ssh_key_type | default('ed25519') }}"
98-
# become_user: "{{ item.name }}" # Commenting out as become_user does not imply become: true
99+
become: true
100+
become_user: "{{ item.name }}"
99101
loop: "{{ basic_users_users }}"
100102
loop_control:
101103
label: "{{ item.name }}"
@@ -112,7 +114,8 @@
112114
manage_dir: false
113115
key: "{{ item.public_key }}"
114116
path: ~/.ssh/authorized_keys
115-
# become_user: "{{ item.item.name }}" # Commenting out as become_user does not imply become: true
117+
become: true
118+
become_user: "{{ item.item.name }}"
116119
loop: "{{ _cluster_ssh_keypair.results }}"
117120
loop_control:
118121
label: "{{ item.item.name }}"
@@ -129,7 +132,8 @@
129132
manage_dir: false
130133
key: "{{ item.public_key }}"
131134
path: ~/.ssh/authorized_keys
132-
# become_user: "{{ item.name }}" # Commenting out as become_user does not imply become: true
135+
become: true
136+
become_user: "{{ item.name }}"
133137
loop: "{{ basic_users_users }}"
134138
loop_control:
135139
label: "{{ item.name }}"

0 commit comments

Comments
 (0)