-
-
Notifications
You must be signed in to change notification settings - Fork 848
Closed
Labels
AcceptedRFC feature request which has been accepted.RFC feature request which has been accepted.CIssue involves or relates to C.Issue involves or relates to C.FeatureIssue or pull request for adding a new feature.Issue or pull request for adding a new feature.Good First IssueA good first issue for new contributors!A good first issue for new contributors!RFCRequest for comments. Feature requests and proposed changes.Request for comments. Feature requests and proposed changes.StatisticsIssue or pull request related to statistical functionality.Issue or pull request related to statistical functionality.difficulty: 2May require some initial design or R&D, but should be straightforward to resolve and/or implement.May require some initial design or R&D, but should be straightforward to resolve and/or implement.priority: NormalNormal priority concern or feature request.Normal priority concern or feature request.
Description
Description
This RFC proposes adding a C implementation, including native Node.js addon, C benchmarks and C examples, for the @stdlib/stats/base/dists/arcsine/cdf
package.
Prerequisites
- Review JavaScript implementation in
lib/main.js
and its required modules to identify allstdlib
functions used. - Verify C implementations exist for each required function.
Related Issues
Questions
No.
Other
Once the implementation is ready including C examples and benchmarks, we should be able to run the following make
commands.
Build native add-on
NODE_ADDONS_PATTERN="@stdlib/stats/base/dists/arcsine/cdf" make install-node-addons
Run C Examples
make examples-c-files FILES="$(pwd)/lib/node_modules/@stdlib/stats/base/dists/arcsine/cdf/examples/c/example.c"
Run C benchmarks
make benchmark-c-files FILES="$(pwd)/lib/node_modules/@stdlib/stats/base/dists/arcsine/cdf/benchmark/c/benchmark.c"
Checklist
- I have read and understood the Code of Conduct.
- Searched for existing issues and pull requests.
- The issue name begins with
RFC:
.
Metadata
Metadata
Assignees
Labels
AcceptedRFC feature request which has been accepted.RFC feature request which has been accepted.CIssue involves or relates to C.Issue involves or relates to C.FeatureIssue or pull request for adding a new feature.Issue or pull request for adding a new feature.Good First IssueA good first issue for new contributors!A good first issue for new contributors!RFCRequest for comments. Feature requests and proposed changes.Request for comments. Feature requests and proposed changes.StatisticsIssue or pull request related to statistical functionality.Issue or pull request related to statistical functionality.difficulty: 2May require some initial design or R&D, but should be straightforward to resolve and/or implement.May require some initial design or R&D, but should be straightforward to resolve and/or implement.priority: NormalNormal priority concern or feature request.Normal priority concern or feature request.