From d775d30b7bce017db4213f3866dc2f55909fdddf Mon Sep 17 00:00:00 2001 From: gururaj1512 Date: Mon, 14 Jul 2025 06:42:03 +0000 Subject: [PATCH 1/2] chore: minor cleanup in `stats/strided/dcovarmtk` --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: passed - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: missing_dependencies - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed --- --- lib/node_modules/@stdlib/stats/strided/dcovarmtk/README.md | 4 ++-- .../@stdlib/stats/strided/dcovarmtk/docs/repl.txt | 6 +++--- .../@stdlib/stats/strided/dcovarmtk/docs/types/test.ts | 2 +- .../@stdlib/stats/strided/dcovarmtk/src/addon.c | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/strided/dcovarmtk/README.md b/lib/node_modules/@stdlib/stats/strided/dcovarmtk/README.md index a784f4ceeb2c..4dcdebf28726 100644 --- a/lib/node_modules/@stdlib/stats/strided/dcovarmtk/README.md +++ b/lib/node_modules/@stdlib/stats/strided/dcovarmtk/README.md @@ -131,7 +131,7 @@ The `N` and stride parameters determine which elements in the strided arrays are var Float64Array = require( '@stdlib/array/float64' ); var x = new Float64Array( [ 1.0, 2.0, 2.0, -7.0, -2.0, 3.0, 4.0, 2.0 ] ); -var y = new Float64Array( [ -7.0, 2.0, 2.0, 1.0, -2.0, 2.0, 3.0, 4.0 ] ); +var y = new Float64Array( [ 2.0, 1.0, 2.0, 1.0, -2.0, 2.0, 3.0, 4.0 ] ); var v = dcovarmtk( 4, 1, 1.25, x, 2, 1.25, y, 2 ); // returns 6.0 @@ -342,7 +342,7 @@ int main( void ) { const int strideX = 2; // Compute the covariance of `x` with itself: - double v = stdlib_strided_dcovarmtk( N, 1, 4.5, x, strideX, 4.5, x, -strideX ); + double v = stdlib_strided_dcovarmtk( N, 1.0, 4.5, x, strideX, 4.5, x, -strideX ); // Print the result: printf( "covariance: %lf\n", v ); diff --git a/lib/node_modules/@stdlib/stats/strided/dcovarmtk/docs/repl.txt b/lib/node_modules/@stdlib/stats/strided/dcovarmtk/docs/repl.txt index e95804003a98..0151ff281b70 100644 --- a/lib/node_modules/@stdlib/stats/strided/dcovarmtk/docs/repl.txt +++ b/lib/node_modules/@stdlib/stats/strided/dcovarmtk/docs/repl.txt @@ -1,5 +1,5 @@ -{{alias}}( N, correction, meanx, x, strideX, meany, y, strideY ) +{{alias}}( N, correction, meanx, x, sx, meany, y, sy ) Computes the covariance of two double-precision floating-point strided arrays provided known means and using a one-pass textbook algorithm. @@ -34,7 +34,7 @@ x: Float64Array First input array. - strideX: integer + sx: integer Stride length of `x`. meany: number @@ -43,7 +43,7 @@ y: Float64Array Second input array. - strideY: integer + sy: integer Stride length of `y`. Returns diff --git a/lib/node_modules/@stdlib/stats/strided/dcovarmtk/docs/types/test.ts b/lib/node_modules/@stdlib/stats/strided/dcovarmtk/docs/types/test.ts index 0d0cc74b5029..b592cbc3c093 100644 --- a/lib/node_modules/@stdlib/stats/strided/dcovarmtk/docs/types/test.ts +++ b/lib/node_modules/@stdlib/stats/strided/dcovarmtk/docs/types/test.ts @@ -39,7 +39,7 @@ import dcovarmtk = require( './index' ); dcovarmtk( undefined, 1, 0.0, x, 1, 0.0, x, 1 ); // $ExpectError dcovarmtk( [], 1, 0.0, x, 1, 0.0, x, 1 ); // $ExpectError dcovarmtk( {}, 1, 0.0, x, 1, 0.0, x, 1 ); // $ExpectError - dcovarmtk( ( x: number ): number => x, 1, 0.0, x, 1, 0.0, x, 1, 0.0, x, 1 ); // $ExpectError + dcovarmtk( ( x: number ): number => x, 1, 0.0, x, 1, 0.0, x, 1 ); // $ExpectError } // The compiler throws an error if the function is provided a second argument which is not a number... diff --git a/lib/node_modules/@stdlib/stats/strided/dcovarmtk/src/addon.c b/lib/node_modules/@stdlib/stats/strided/dcovarmtk/src/addon.c index 2b743de7a931..96224e5796b4 100644 --- a/lib/node_modules/@stdlib/stats/strided/dcovarmtk/src/addon.c +++ b/lib/node_modules/@stdlib/stats/strided/dcovarmtk/src/addon.c @@ -41,8 +41,8 @@ static napi_value addon( napi_env env, napi_callback_info info ) { STDLIB_NAPI_ARGV_DOUBLE( env, meany, argv, 5 ); STDLIB_NAPI_ARGV_INT64( env, strideX, argv, 4 ); STDLIB_NAPI_ARGV_INT64( env, strideY, argv, 7 ); - STDLIB_NAPI_ARGV_STRIDED_FLOAT64ARRAY( env, X, N, strideX, argv, 3 ) - STDLIB_NAPI_ARGV_STRIDED_FLOAT64ARRAY( env, Y, N, strideY, argv, 6 ) + STDLIB_NAPI_ARGV_STRIDED_FLOAT64ARRAY( env, X, N, strideX, argv, 3 ); + STDLIB_NAPI_ARGV_STRIDED_FLOAT64ARRAY( env, Y, N, strideY, argv, 6 ); STDLIB_NAPI_CREATE_DOUBLE( env, API_SUFFIX(stdlib_strided_dcovarmtk)( N, correction, meanx, X, strideX, meany, Y, strideY ), v ); return v; } From 1fb3364150022200c0d395992d5b9fb577db0933 Mon Sep 17 00:00:00 2001 From: Gururaj Gurram <143020143+gururaj1512@users.noreply.github.com> Date: Mon, 14 Jul 2025 14:30:20 +0530 Subject: [PATCH 2/2] fix: return correct value Signed-off-by: Gururaj Gurram <143020143+gururaj1512@users.noreply.github.com> --- lib/node_modules/@stdlib/stats/strided/dcovarmtk/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/stats/strided/dcovarmtk/README.md b/lib/node_modules/@stdlib/stats/strided/dcovarmtk/README.md index 4dcdebf28726..5b246edf528e 100644 --- a/lib/node_modules/@stdlib/stats/strided/dcovarmtk/README.md +++ b/lib/node_modules/@stdlib/stats/strided/dcovarmtk/README.md @@ -134,7 +134,7 @@ var x = new Float64Array( [ 1.0, 2.0, 2.0, -7.0, -2.0, 3.0, 4.0, 2.0 ] ); var y = new Float64Array( [ 2.0, 1.0, 2.0, 1.0, -2.0, 2.0, 3.0, 4.0 ] ); var v = dcovarmtk( 4, 1, 1.25, x, 2, 1.25, y, 2 ); -// returns 6.0 +// returns 5.25 ``` Note that indexing is relative to the first index. To introduce an offset, use [`typed array`][mdn-typed-array] views.