From 0d7d099475bd4a73a32a872578831bcc6c486210 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gautier=20Ben=20A=C3=AFm?= <48261497+GauBen@users.noreply.github.com> Date: Tue, 15 Jul 2025 23:11:49 +0200 Subject: [PATCH 1/5] feat: support `params` page prop --- docs/rules/valid-prop-names-in-kit-pages.md | 1 + .../src/rules/valid-prop-names-in-kit-pages.ts | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/rules/valid-prop-names-in-kit-pages.md b/docs/rules/valid-prop-names-in-kit-pages.md index 3f3323c61..a6538ea2f 100644 --- a/docs/rules/valid-prop-names-in-kit-pages.md +++ b/docs/rules/valid-prop-names-in-kit-pages.md @@ -26,6 +26,7 @@ At SvelteKit v1.0.0-next.405, instead of having multiple props corresponding to export let data; export let errors; export let form; + export let params; export let snapshot; // export let { data, errors } = { data: {}, errors: {} } diff --git a/packages/eslint-plugin-svelte/src/rules/valid-prop-names-in-kit-pages.ts b/packages/eslint-plugin-svelte/src/rules/valid-prop-names-in-kit-pages.ts index 5554b9cf7..071853782 100644 --- a/packages/eslint-plugin-svelte/src/rules/valid-prop-names-in-kit-pages.ts +++ b/packages/eslint-plugin-svelte/src/rules/valid-prop-names-in-kit-pages.ts @@ -4,7 +4,7 @@ import { createRule } from '../utils/index.js'; import type { RuleContext } from '../types.js'; import { getSvelteVersion } from '../utils/svelte-context.js'; -const EXPECTED_PROP_NAMES = ['data', 'errors', 'form', 'snapshot']; +const EXPECTED_PROP_NAMES = ['data', 'errors', 'form', 'params', 'snapshot']; const EXPECTED_PROP_NAMES_SVELTE5 = [...EXPECTED_PROP_NAMES, 'children']; function checkProp( From 80cd3524485ea937fe1a8353d7bfa02b255bedc0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gautier=20Ben=20A=C3=AFm?= <48261497+GauBen@users.noreply.github.com> Date: Tue, 15 Jul 2025 23:15:13 +0200 Subject: [PATCH 2/5] Create strange-actors-greet.md --- .changeset/strange-actors-greet.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/strange-actors-greet.md diff --git a/.changeset/strange-actors-greet.md b/.changeset/strange-actors-greet.md new file mode 100644 index 000000000..1d9f65fdf --- /dev/null +++ b/.changeset/strange-actors-greet.md @@ -0,0 +1,5 @@ +--- +"eslint-plugin-svelte": patch +--- + +feat(valid-prop-names-in-kit-pages): add support for the new `params` page prop From 496f3ae8539a30a58b52a2bf636c199133dc7bdf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gautier=20Ben=20A=C3=AFm?= <48261497+GauBen@users.noreply.github.com> Date: Wed, 16 Jul 2025 14:14:06 +0200 Subject: [PATCH 3/5] add tests --- .../valid-prop-names-in-kit-pages/valid/svelte5/+page.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/valid-prop-names-in-kit-pages/valid/svelte5/+page.svelte b/packages/eslint-plugin-svelte/tests/fixtures/rules/valid-prop-names-in-kit-pages/valid/svelte5/+page.svelte index 66723409f..91dea8884 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/valid-prop-names-in-kit-pages/valid/svelte5/+page.svelte +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/valid-prop-names-in-kit-pages/valid/svelte5/+page.svelte @@ -1,5 +1,5 @@