From 17aa86b8583a8480d2bcac383f6eb84686019ecf Mon Sep 17 00:00:00 2001 From: Dimitri Bouniol Date: Sat, 1 Feb 2025 13:16:36 -0800 Subject: [PATCH 1/2] Fixed an issue where a PROJECT_NAME was required even though a template file was provided --- .github/workflows/scripts/check-license-header.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/scripts/check-license-header.sh b/.github/workflows/scripts/check-license-header.sh index 5f84566..ad04ead 100755 --- a/.github/workflows/scripts/check-license-header.sh +++ b/.github/workflows/scripts/check-license-header.sh @@ -17,12 +17,11 @@ log() { printf -- "** %s\n" "$*" >&2; } error() { printf -- "** ERROR: %s\n" "$*" >&2; } fatal() { error "$@"; exit 1; } -test -n "${PROJECT_NAME:-}" || fatal "PROJECT_NAME unset" - if [ -f .license_header_template ]; then # allow projects to override the license header template expected_file_header_template=$(cat .license_header_template) else + test -n "${PROJECT_NAME:-}" || fatal "PROJECT_NAME unset" expected_file_header_template="@@===----------------------------------------------------------------------===@@ @@ @@ This source file is part of the ${PROJECT_NAME} open source project From 2ad4ac1f08b3603dcc1ae00075959c17df67383d Mon Sep 17 00:00:00 2001 From: Dimitri Bouniol Date: Sat, 1 Feb 2025 13:21:44 -0800 Subject: [PATCH 2/2] Updated `license_header_check_project_name` to no longer be required Fixes #76 --- .github/workflows/soundness.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/soundness.yml b/.github/workflows/soundness.yml index cb5c55a..418db84 100644 --- a/.github/workflows/soundness.yml +++ b/.github/workflows/soundness.yml @@ -37,8 +37,8 @@ on: default: true license_header_check_project_name: type: string - description: "Name of the project called out in the license header." - required: true + description: "Name of the project called out in the license header. Required unless `license_header_check_enabled` is false or a `.license_header_template` file is present." + default: "" broken_symlink_check_enabled: type: boolean description: "Boolean to enable the broken symlink check job. Defaults to true."