Skip to content

Commit c163e0f

Browse files
committed
[Tests] Make OS features consistent
lit.py currently allows any substring of `target_triple` to be used as a feature in REQUIRES/UNSUPPORTED/XFAIL. This results in various forms of the OS spread across the tests and is also somewhat confusing since they aren't actually listed in the available features. Modify all OS-related features to use the `OS=` version that Swift adds instead. We can later remove `config.target_triple` so that these don't the non-OS versions don't work in the first place.
1 parent de47a77 commit c163e0f

File tree

62 files changed

+64
-65
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

62 files changed

+64
-65
lines changed

test/AutoDiff/compiler_crashers_fixed/rdar71191415-nested-differentiation-of-extension-method-optimized.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// RUN: %target-build-swift -O %s
22

33
// FIXME(rdar://89055298)
4-
// UNSUPPORTED: linux
4+
// UNSUPPORTED: OS=linux-gnu
55

66
// rdar://71191415
77

test/Concurrency/Reflection/reflect_task.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
// UNSUPPORTED: use_os_stdlib
1111
// UNSUPPORTED: back_deployment_runtime
1212
//
13-
// UNSUPPORTED: OS=macosx,ios,watchos,tvos
13+
// UNSUPPORTED: OS=macosx, OS=ios, OS=watchos, OS=tvos
1414

1515
import Swift
1616
import _Concurrency

test/Concurrency/Runtime/async_taskgroup_asynciterator_semantics.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
// REQUIRES: concurrency
44
// REQUIRES: concurrency_runtime
55
// UNSUPPORTED: back_deployment_runtime
6-
// UNSUPPORTED: linux
6+
// UNSUPPORTED: OS=linux-gnu
77

88
// REQUIRES: rdar86028226
99

test/Concurrency/Runtime/async_taskgroup_is_asyncsequence.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
// REQUIRES: concurrency_runtime
88
// UNSUPPORTED: back_deployment_runtime
99

10-
// UNSUPPORTED: linux
10+
// UNSUPPORTED: OS=linux-gnu
1111

1212
@available(SwiftStdlib 5.1, *)
1313
func test_taskGroup_is_asyncSequence() async {

test/Concurrency/Runtime/executor_deinit1.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
// UNSUPPORTED: back_deployment_runtime
88

99
// https://bugs.swift.org/browse/SR-14461
10-
// UNSUPPORTED: linux
10+
// UNSUPPORTED: OS=linux-gnu
1111

1212
// REQUIRES: rdar78325660
1313

test/DebugInfo/local-vars.swift.gyb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
// all. There are other tests testing liveness and representation.
44

55
// rdar://problem/57611302
6-
// XFAIL: windows
6+
// XFAIL: OS=windows-msvc
77

88
// RUN: %gyb %s -o %t.swift
99
// RUN: %target-swift-frontend %t.swift -g -emit-ir -o - | %FileCheck %t.swift

test/Distributed/Runtime/distributed_actor_cross_module_final_class_adhoc_requirement_not_optimized_away.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
// UNSUPPORTED: back_deployment_runtime
1414

1515
// FIXME(distributed): Distributed actors currently have some issues on windows, isRemote always returns false. rdar://82593574
16-
// UNSUPPORTED: windows
16+
// UNSUPPORTED: OS=windows-msvc
1717

1818
import Distributed
1919
import FakeDistributedActorSystems

test/Distributed/Runtime/distributed_actor_deinit.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
// UNSUPPORTED: back_deployment_runtime
99

1010
// FIXME(distributed): Distributed actors currently have some issues on windows, isRemote always returns false. rdar://82593574
11-
// UNSUPPORTED: windows
11+
// UNSUPPORTED: OS=windows-msvc
1212

1313
import Distributed
1414

test/Distributed/Runtime/distributed_actor_func_calls_remoteCall_echo.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
// UNSUPPORTED: back_deployment_runtime
1313

1414
// FIXME(distributed): Distributed actors currently have some issues on windows, isRemote always returns false. rdar://82593574
15-
// UNSUPPORTED: windows
15+
// UNSUPPORTED: OS=windows-msvc
1616

1717
import Distributed
1818
import FakeDistributedActorSystems

test/Distributed/Runtime/distributed_actor_func_calls_remoteCall_empty.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
// UNSUPPORTED: back_deployment_runtime
1313

1414
// FIXME(distributed): Distributed actors currently have some issues on windows, isRemote always returns false. rdar://82593574
15-
// UNSUPPORTED: windows
15+
// UNSUPPORTED: OS=windows-msvc
1616

1717
import Distributed
1818
import FakeDistributedActorSystems

0 commit comments

Comments
 (0)