SILGen: Have emitSemanticStore cast off concurrency annotations. #83107
+25
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
If a function is being semantically treated as having different concurrency annotations because of a `@preconcurrency` import or language mode setting, then SILGen may try to store an argument or result for a call using a value that differs only in concurrency annotations, which can be safely bitcast away. Fixes rdar://154520999
jckarter
force-pushed
the
semantic-store-preconcurrency
branch
from
75c639a to
0e94c63
Compare
|
@swift-ci Please test |
|
@swift-ci Please test macOS |
1 similar comment
|
@swift-ci Please test macOS |
xedin
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a function is being semantically treated as having different concurrency annotations because of a
@preconcurrencyimport or language mode setting, then SILGen may try to store an argument or result for a call using a value that differs only in concurrency annotations, which can be safely bitcast away.Fixes rdar://154520999