Add an explicit retain() function and fix a ref counting bug

Author: j-f1

Runtime/src/index.ts

@@ -411,6 +411,9 @@ export class SwiftRuntime {
                 // Call `.slice()` to copy the memory
                 writeUint32(result_obj, this.heap.retain(array.slice()));
             },
+            swjs_retain: (ref: ref) => {
+                this.heap.retain(this.heap.referenceHeap(ref))
+            },
             swjs_release: (ref: ref) => {
                 this.heap.release(ref)
             }

Sources/JavaScriptKit/JSTypedArray.swift

@@ -21,6 +21,7 @@ public class JSTypedArray<Element>: JSObjectRef, ExpressibleByArrayLiteral where
 
     public init(length: Int) {
         super.init(id: Element.typedArrayClass.new(length).id)
+        _retain(id)
     }
 
     required public convenience init(arrayLiteral elements: Element...) {

Sources/JavaScriptKit/XcodeSupport.swift

@@ -72,6 +72,7 @@ import _CJavaScriptKit
         _: JavaScriptHostFuncRef,
         _: UnsafePointer<JavaScriptObjectRef>!
     ) { fatalError() }
+    func _retain(_: JavaScriptObjectRef) { fatalError() }
     func _release(_: JavaScriptObjectRef) { fatalError() }
     func _create_typed_array<T: TypedArrayElement>(
         _: JavaScriptTypedArrayKind,

Sources/_CJavaScriptKit/include/_CJavaScriptKit.h

@@ -106,6 +106,10 @@ __attribute__((__import_module__("javascript_kit"),
 _create_function(const JavaScriptHostFuncRef host_func_id,
                  const JavaScriptObjectRef *func_ref_ptr);
 
+__attribute__((__import_module__("javascript_kit"),
+               __import_name__("swjs_retain"))) extern void
+_retain(const JavaScriptObjectRef ref);
+
 __attribute__((__import_module__("javascript_kit"),
                __import_name__("swjs_release"))) extern void
 _release(const JavaScriptObjectRef ref);