Narrow existing return types on private/internal/final/test methods

Author: nicolas-grekas

MessageBirdTransportFactory.php

@@ -14,17 +14,13 @@
 use Symfony\Component\Notifier\Exception\UnsupportedSchemeException;
 use Symfony\Component\Notifier\Transport\AbstractTransportFactory;
 use Symfony\Component\Notifier\Transport\Dsn;
-use Symfony\Component\Notifier\Transport\TransportInterface;
 
 /**
  * @author Vasilij Duško <[email protected]>
  */
 final class MessageBirdTransportFactory extends AbstractTransportFactory
 {
-    /**
-     * @return MessageBirdTransport
-     */
-    public function create(Dsn $dsn): TransportInterface
+    public function create(Dsn $dsn): MessageBirdTransport
     {
         $scheme = $dsn->getScheme();
 

Tests/MessageBirdTransportFactoryTest.php

@@ -13,14 +13,10 @@
 
 use Symfony\Component\Notifier\Bridge\MessageBird\MessageBirdTransportFactory;
 use Symfony\Component\Notifier\Test\TransportFactoryTestCase;
-use Symfony\Component\Notifier\Transport\TransportFactoryInterface;
 
 final class MessageBirdTransportFactoryTest extends TransportFactoryTestCase
 {
-    /**
-     * @return MessageBirdTransportFactory
-     */
-    public function createFactory(): TransportFactoryInterface
+    public function createFactory(): MessageBirdTransportFactory
     {
         return new MessageBirdTransportFactory();
     }

Tests/MessageBirdTransportTest.php

@@ -16,15 +16,11 @@
 use Symfony\Component\Notifier\Message\MessageInterface;
 use Symfony\Component\Notifier\Message\SmsMessage;
 use Symfony\Component\Notifier\Test\TransportTestCase;
-use Symfony\Component\Notifier\Transport\TransportInterface;
 use Symfony\Contracts\HttpClient\HttpClientInterface;
 
 final class MessageBirdTransportTest extends TransportTestCase
 {
-    /**
-     * @return MessageBirdTransport
-     */
-    public function createTransport(HttpClientInterface $client = null): TransportInterface
+    public function createTransport(HttpClientInterface $client = null): MessageBirdTransport
     {
         return new MessageBirdTransport('token', 'from', $client ?? $this->createMock(HttpClientInterface::class));
     }