Skip to content

Commit a13fe17

Browse files
committed
fix(server): input validation class validator
1 parent 62c175d commit a13fe17

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

packages/twenty-server/src/engine/metadata-modules/object-metadata/dtos/update-object.input.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { Field, InputType } from '@nestjs/graphql';
22

33
import { BeforeUpdateOne } from '@ptc-org/nestjs-query-graphql';
4+
import { Type } from 'class-transformer';
45
import {
56
IsBoolean,
67
IsNotEmpty,
@@ -77,6 +78,7 @@ export class UpdateObjectPayload {
7778
@InputType()
7879
@BeforeUpdateOne(BeforeUpdateOneObject)
7980
export class UpdateOneObjectInput {
81+
@Type(() => UpdateObjectPayload)
8082
@ValidateNested()
8183
@Field(() => UpdateObjectPayload)
8284
update: UpdateObjectPayload;

packages/twenty-server/src/engine/metadata-modules/utils/validate-metadata-identifier-field-metadata-id.utils.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import {
22
isDefined,
33
isLabelIdentifierFieldMetadataTypes,
4-
isValidUuid,
54
} from 'twenty-shared/utils';
65

76
import { FieldMetadataInterface } from 'src/engine/metadata-modules/field-metadata/interfaces/field-metadata.interface';
@@ -38,11 +37,7 @@ const validateMetadataIdentifierFieldMetadataIdOrThrow = ({
3837
);
3938

4039
const validators: Array<Validator> = [
41-
{
42-
validator: ({ identifierFieldMetadataId }) =>
43-
!isValidUuid(identifierFieldMetadataId),
44-
label: 'identifierFieldMetadataId must be a valid uuid',
45-
},
40+
// TODO We should programmatically run the UpdateObjectPayload validation here
4641
{
4742
validator: ({ matchingFieldMetadata }) =>
4843
!isDefined(matchingFieldMetadata),

0 commit comments

Comments
 (0)