Skip to content

Update input bindings in Temperature converter 7GUIs example #1600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

anubra266
Copy link

@anubra266 anubra266 commented Mar 6, 2022

Description of Problem

In the Temperature Converter (7GUIs) example, the inputs still use the @change directive, so it doesn't work.

Proposed Solution

I updated them to use the @input directive.

Additional Information

I just learnt vue between yesterday and today, I was practicing the examples when I encountered this, so I appreciate any feedback.

@netlify
Copy link

netlify bot commented Mar 6, 2022

✔️ Deploy Preview for vuejs ready!

🔨 Explore the source changes: d6a5b06

🔍 Inspect the deploy log: https://app.netlify.com/sites/vuejs/deploys/62252ce8447eaa0007616a94

😎 Browse the preview: https://deploy-preview-1600--vuejs.netlify.app

@skirtles-code
Copy link
Contributor

Thanks for the PR!

I saw the conversation about this on Vue Land. Based on that I believe this was simply a misunderstanding and no change is actually required.

@anubra266 anubra266 deleted the fix/update-input-bindings branch March 7, 2022 01:29
@ElMassimo
Copy link
Contributor

ElMassimo commented Apr 5, 2022

@skirtles-code What was the discussion in Vue Land?

By using change, typing in the input does not reflect the value, making the example less interactive (and would seem like a bug to most users).

For reference, the Svelte demo uses input instead of change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants