Db: Remove unnecessary 'termsId' from 'WCGlobalAttributeModel' table

FYI: Similarly to this 364c18d change,
which completely removed everything 'WCAttributeTermModel', this related
'termsId' column/code is also unnecessary and can be safely removed from
its associated 'WCGlobalAttributeModel' table.

Author: ParaskP7

WooCommerce/src/main/kotlin/com/woocommerce/android/model/ProductGlobalAttribute.kt

@@ -16,7 +16,6 @@ data class ProductGlobalAttribute(
     val type: String,
     val orderBy: String,
     val hasArchives: Boolean,
-    val termsId: String,
     val remoteId: Long
 ) : Parcelable {
     fun toDataModel(cachedAttribute: WCGlobalAttributeModel? = null): WCGlobalAttributeModel {
@@ -28,7 +27,6 @@ data class ProductGlobalAttribute(
             it.type = type
             it.orderBy = orderBy
             it.hasArchives = hasArchives
-            it.termsId = termsId
             it.remoteId = remoteId.toInt()
         }
     }
@@ -58,6 +56,5 @@ fun WCGlobalAttributeModel.toAppModel(): ProductGlobalAttribute {
         type = this.type,
         orderBy = this.orderBy,
         hasArchives = this.hasArchives,
-        termsId = this.termsId
     )
 }

libs/fluxc-plugin/src/main/kotlin/org/wordpress/android/fluxc/model/attribute/WCGlobalAttributeModel.kt

@@ -15,7 +15,6 @@ data class WCGlobalAttributeModel(
     @Column var type: String = "",
     @Column var orderBy: String = "",
     @Column var hasArchives: Boolean = false,
-    @Column var termsId: String = "",
     @Column var remoteId: Int = 0
 ) : Identifiable {
     override fun setId(id: Int) {

libs/fluxc-plugin/src/main/kotlin/org/wordpress/android/fluxc/persistence/WCGlobalAttributeSqlUtils.kt

@@ -63,13 +63,6 @@ object WCGlobalAttributeSqlUtils {
                     }
                     ?: insertSingleAttribute(attribute)
 
-    fun updateSingleAttributeTermsMapping(attributeID: Int, termsMapping: String, siteID: Int) =
-        fetchSingleStoredAttribute(attributeID, siteID)
-                ?.let {
-                    it.termsId = termsMapping
-                    updateSingleStoredAttribute(it, siteID)
-                }
-
     private fun deleteCompleteAttributesList(siteID: Int) =
             WellSql.delete(WCGlobalAttributeModel::class.java)
                     .where().beginGroup()

libs/fluxc-plugin/src/main/kotlin/org/wordpress/android/fluxc/store/WCGlobalAttributeStore.kt

@@ -14,7 +14,6 @@ import org.wordpress.android.fluxc.persistence.WCGlobalAttributeSqlUtils.getCurr
 import org.wordpress.android.fluxc.persistence.WCGlobalAttributeSqlUtils.insertFromScratchCompleteAttributesList
 import org.wordpress.android.fluxc.persistence.WCGlobalAttributeSqlUtils.insertOrUpdateSingleAttribute
 import org.wordpress.android.fluxc.persistence.WCGlobalAttributeSqlUtils.insertSingleAttribute
-import org.wordpress.android.fluxc.persistence.WCGlobalAttributeSqlUtils.updateSingleAttributeTermsMapping
 import org.wordpress.android.fluxc.persistence.WCGlobalAttributeSqlUtils.updateSingleStoredAttribute
 import org.wordpress.android.fluxc.tools.CoroutineEngine
 import org.wordpress.android.util.AppLog
@@ -58,15 +57,6 @@ class WCGlobalAttributeStore @Inject constructor(
         pageSize: Int = DEFAULT_PAGE_SIZE
     ) = restClient.fetchAllAttributeTerms(site, attributeID, page, pageSize)
             .result?.map { mapper.responseToAttributeTermModel(it, attributeID.toInt(), site) }
-            ?.apply {
-                map { it.remoteId.toString() }
-                        .takeIf { it.isNotEmpty() }
-                        ?.reduce { total, new -> "$total;$new" }
-                        ?.let { termsId ->
-                            updateSingleAttributeTermsMapping(attributeID.toInt(), termsId, site.id)
-                                    ?: handleMissingAttribute(site, attributeID, termsId)
-                        }
-            }
             ?.let { WooResult(it) }
 
     suspend fun fetchAttribute(
@@ -183,16 +173,6 @@ class WCGlobalAttributeStore @Inject constructor(
                         ?: WooResult(WooError(GENERIC_ERROR, UNKNOWN))
             }
 
-    private suspend fun handleMissingAttribute(
-        site: SiteModel,
-        attributeID: Long,
-        termsId: String
-    ) {
-        fetchAttribute(site, attributeID)
-                .model
-                ?.let { updateSingleAttributeTermsMapping(attributeID.toInt(), termsId, site.id) }
-    }
-
     companion object {
         const val DEFAULT_PAGE_SIZE = 100
         const val DEFAULT_PAGE_INDEX = 1