Skip to content

Commit f320bc0

Browse files
ChrsMarkzeck-ops
authored andcommitted
[chore][receivercreator] Replace positional arguements with named (open-telemetry#36910)
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PR replace positional arguements with named in struct initialization. Addresses open-telemetry#36581 (comment) Signed-off-by: ChrsMark <[email protected]>
1 parent 257eb5c commit f320bc0

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

receiver/receivercreator/config_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ func TestLoadConfig(t *testing.T) {
9090
Rule: `type == "port"`,
9191
ResourceAttributes: map[string]any{"one": "two"},
9292
rule: portRule,
93-
signals: receiverSignals{true, true, true},
93+
signals: receiverSignals{metrics: true, logs: true, traces: true},
9494
},
9595
"nop/1": {
9696
receiverConfig: receiverConfig{
@@ -103,7 +103,7 @@ func TestLoadConfig(t *testing.T) {
103103
Rule: `type == "port"`,
104104
ResourceAttributes: map[string]any{"two": "three"},
105105
rule: portRule,
106-
signals: receiverSignals{true, true, true},
106+
signals: receiverSignals{metrics: true, logs: true, traces: true},
107107
},
108108
},
109109
WatchObservers: []component.ID{

receiver/receivercreator/discovery.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ func (builder *k8sHintsBuilder) createScraper(
124124
}
125125

126126
recTemplate, err := newReceiverTemplate(fmt.Sprintf("%v/%v_%v", subreceiverKey, pod.UID, port), userConfMap)
127-
recTemplate.signals = receiverSignals{true, false, false}
127+
recTemplate.signals = receiverSignals{metrics: true, logs: false, traces: false}
128128

129129
return &recTemplate, err
130130
}

receiver/receivercreator/observerhandler_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ func TestOnAddForMetrics(t *testing.T) {
7878
rule: portRule,
7979
Rule: `type == "port"`,
8080
ResourceAttributes: map[string]any{},
81-
signals: receiverSignals{true, true, true},
81+
signals: receiverSignals{metrics: true, logs: true, traces: true},
8282
},
8383
}
8484

0 commit comments

Comments
 (0)