Switching to upstream version of JWT package with JWK classes added #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using this library, I came across the following error in doing a
composer install
:It turns out that this package conflicts with the google/auth library and other libraries which use the firebase version.
I believe the reason for using the fork is so that the JWK class exists, however I recently had a pull request merged and now released, which means that the JWK class is available in the latest version of
firebase/php-jwt
.As a result of all this, I'm updating the composer.json to use this more popular version of the package, instead of the fork. Through code review there was one minor change I had to make to the fproject version, which means I did need to update this LTI package's usage of
JWK::parseKey()
toJWK::parseKeySet()
. Apart from that I did not find other changes.I did some basic manual testing and everything is still working as expected.