Skip to content

feat(editing-support): adding codecompanion-nvim #1562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Jul 10, 2025
Merged

Conversation

Yorizel
Copy link
Contributor

@Yorizel Yorizel commented Jun 27, 2025

No description provided.

Copy link

github-actions bot commented Jun 27, 2025

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@Yorizel Yorizel marked this pull request as draft June 27, 2025 23:17
@Yorizel Yorizel marked this pull request as ready for review June 28, 2025 15:33
@Yorizel
Copy link
Contributor Author

Yorizel commented Jun 28, 2025

@Uzaaft

@azdanov azdanov linked an issue Jun 29, 2025 that may be closed by this pull request
@Yorizel
Copy link
Contributor Author

Yorizel commented Jul 1, 2025

@azdanov @Uzaaft

@azdanov
Copy link
Contributor

azdanov commented Jul 2, 2025

Looks good! I'll test drive this for a day to see how it works.

@azdanov
Copy link
Contributor

azdanov commented Jul 2, 2025

It looks odd with heirline since the thinking indicator is added at the end, so it pushes everything to the left. A lot of distraction happening

@Yorizel
Copy link
Contributor Author

Yorizel commented Jul 2, 2025

🤔

@Yorizel
Copy link
Contributor Author

Yorizel commented Jul 2, 2025

i will just remove the heirline integration for now

@azdanov
Copy link
Contributor

azdanov commented Jul 2, 2025

You can try https://github.com/azdanov/dotfiles/blob/main/.config%2Fnvim%2Flua%2Fplugins%2Futils%2Fspinner.lua

Can see how it works. Looks like an acceptable solution, since some requests can take dozens of seconds

@Uzaaft Uzaaft marked this pull request as draft July 3, 2025 08:59
@Uzaaft
Copy link
Member

Uzaaft commented Jul 3, 2025

just marked this as a draft until the details are figured out.

@azdanov
Copy link
Contributor

azdanov commented Jul 5, 2025

olimorris/codecompanion.nvim#1717 (comment)

This could be used for the history plugin to auto generate titles. But maybe it's not good if the user has a free tier and it will exhaust it fast.

@Yorizel
Copy link
Contributor Author

Yorizel commented Jul 5, 2025

i will take a loot at it now

@Yorizel
Copy link
Contributor Author

Yorizel commented Jul 5, 2025

@azdanov

@Yorizel Yorizel requested a review from azdanov July 5, 2025 17:51
@Yorizel Yorizel marked this pull request as ready for review July 7, 2025 14:53
@Uzaaft
Copy link
Member

Uzaaft commented Jul 8, 2025

@Yorizel Github is acting up at my side lol or else I would have reviewed this now:
image

@Yorizel
Copy link
Contributor Author

Yorizel commented Jul 8, 2025

github is doing me dirty

@Yorizel
Copy link
Contributor Author

Yorizel commented Jul 8, 2025

Copy link
Member

@Uzaaft Uzaaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, the rest looks nice.

@Yorizel Yorizel requested a review from Uzaaft July 10, 2025 14:13
@Uzaaft Uzaaft merged commit c44cdc0 into AstroNvim:main Jul 10, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create codecompanion pack
3 participants