Skip to content

Nox flake8 local run is not reporting linting issues #111

@priyaananthasankar

Description

@priyaananthasankar

How to reproduce:

  1. Create a linting error eg: Whitespace before a doc string summary comment, like the one in this line: https://github.com/Azure/azure-functions-durable-python/blob/dev/azure/durable_functions/models/DurableOrchestrationContext.py#L16 where we can insert a space between """ and "Context" to produce the following linter error:

D210 No whitespaces allowed surrounding docstring text

  1. Run nox --sessions lint task locally and flake8 doesn't fail.

  2. Run flake8 ./azure/durable_functions and it reports the linter issue.

  3. Now activate the virtual environment created by nox in ./.nox/lint folder.

  4. Run flake8 ./azure/durable_functions => it does not report the linter issue

Need further investigation as to why flake8 doesn't report linter errors when run via nox tool.
Due to this, linter errors can only be caught through pipeline leading to multiple PR commits. Or through GitHub Actions.

Need to enable developer to be able to run flake8 with confidence through Nox.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions