Skip to content

Get shared memory directories (in Unix) from AppSettings #7239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 25, 2021
Merged

Get shared memory directories (in Unix) from AppSettings #7239

merged 8 commits into from
Mar 25, 2021

Conversation

gohar94
Copy link
Contributor

@gohar94 gohar94 commented Mar 20, 2021

Issue describing the changes in this PR

Provides ability to specify custom paths for use with shared memory in Unix. If not provided, the default (/dev/shm) is used.
This can be helpful when running on macOS, for example, where the user needs to create a volume manually before it can be used for shared memory data transfer and /dev/shm is not allowed in macOS.

resolves #issue_for_this_pr

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@gohar94 gohar94 linked an issue Mar 20, 2021 that may be closed by this pull request
Shared memory data transfer between Functions host and out-of-proc workers for HTTP body #6832
Open
@gohar94 gohar94 removed a link to an issue Mar 20, 2021
Shared memory data transfer between Functions host and out-of-proc workers for HTTP body #6832
Open
@gohar94 gohar94 linked an issue Mar 20, 2021 that may be closed by this pull request
Shared memory data transfer between Functions host and out-of-proc workers for binary data #6791
Closed
@gohar94 gohar94 self-assigned this Mar 20, 2021
@gohar94 gohar94 requested review from goiri, pragnagopa and vrdmr March 20, 2021 02:24
goiri
goiri reviewed Mar 20, 2021
View reviewed changes
@pragnagopa pragnagopa requested a review from fabiocav March 23, 2021 17:34
goiri
goiri previously approved these changes Mar 23, 2021
View reviewed changes
@vrdmr vrdmr requested a review from AnatoliB March 23, 2021 19:03
pragnagopa
pragnagopa reviewed Mar 24, 2021
View reviewed changes
Copy link
Member

@pragnagopa pragnagopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added minor comments

@gohar94 gohar94 requested a review from pragnagopa March 24, 2021 21:13
@pragnagopa
Copy link
Member

@fabiocav - flagging here that We should have build pipeline for Linux that runs unit tests. Opened #7250 to track it.

@gohar94 gohar94 merged commit f886d8c into dev Mar 25, 2021
@gohar94 gohar94 deleted the gochaudh/shared_mem_directories branch March 25, 2021 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goiri goiri goiri left review comments

@pragnagopa pragnagopa pragnagopa approved these changes

@vrdmr vrdmr Awaiting requested review from vrdmr

@fabiocav fabiocav Awaiting requested review from fabiocav

@AnatoliB AnatoliB Awaiting requested review from AnatoliB

Assignees

@gohar94 gohar94

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shared memory data transfer between Functions host and out-of-proc workers for binary data
4 participants
@gohar94 @pragnagopa @vrdmr @goiri