-
Notifications
You must be signed in to change notification settings - Fork 44
feature: add before/after InvocationRequest hooks #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
No pipelines are associated with this pull request. |
mhoeger
reviewed
Oct 20, 2020
mhoeger
reviewed
Oct 20, 2020
mhoeger
reviewed
Oct 20, 2020
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
mhoeger
approved these changes
Oct 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM - on registering async functions, since it's not like a one line change, let's just cross that bridge when we get there.
Thanks!!
mhoeger
pushed a commit
to mhoeger/azure-functions-nodejs-worker
that referenced
this pull request
Oct 26, 2020
* feature: add before/after InvocationRequest hooks * rm return workerChannel * refactor to register cb pattern * remove double callback on promise resolve
mhoeger
pushed a commit
to mhoeger/azure-functions-nodejs-worker
that referenced
this pull request
Oct 26, 2020
* feature: add before/after InvocationRequest hooks * rm return workerChannel * refactor to register cb pattern * remove double callback on promise resolve
mhoeger
added a commit
that referenced
this pull request
Oct 27, 2020
* feature: add before/after InvocationRequest hooks (#339) * feature: add before/after InvocationRequest hooks * rm return workerChannel * refactor to register cb pattern * remove double callback on promise resolve * revert changes * Re-added before / after invocation tests refactored for this branch Co-authored-by: Mark Wolff <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied from #338
Adds two
InvocationRequest
hooks toWorkerChannel
to enable context correlation and node.js worker APM instrumentation. Sample use case for Azure Monitor node.js SDK.invocationRequestBefore
:(context, userFunction) => contextWrappedUserFunction
invocationRequestAfter
:() => void
In App Insights SDK,
setupFunctionsInvocationHooks
would be defined: