Skip to content

Reload additional modules that user might need #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2019
Merged

Reload additional modules that user might need #539

merged 1 commit into from
Sep 4, 2019

Conversation

maiqbal11
Copy link
Contributor

Fixes #529

@maiqbal11 maiqbal11 requested a review from Hazhzeng September 3, 2019 22:26
@maiqbal11
Copy link
Contributor Author

@Hazhzeng, could you take look when you have some time? Should be a straightforward fix.

Hazhzeng
Hazhzeng approved these changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@Hazhzeng Hazhzeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, you predicted it! LGTM :)

@Hazhzeng Hazhzeng merged commit 7896127 into dev Sep 4, 2019
@Hazhzeng Hazhzeng deleted the reload-modules branch January 28, 2020 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Hazhzeng Hazhzeng Hazhzeng approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Module cannot be imported when running remotely but works locally.
2 participants
@maiqbal11 @Hazhzeng