-
Notifications
You must be signed in to change notification settings - Fork 5k
Caching blobs in shared memory for faster I/O #20209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps: For data-plane/track 2 SDKs Issue the following command as a pull request comment:
For track 1 management-plane SDKsPlease open a separate PR and to your service SDK path in this file. Once that PR has been merged, you can re-run the pipeline to trigger the verification. |
...storage/Microsoft.Azure.WebJobs.Extensions.Storage.Blobs/src/Bindings/NotifyingBlobStream.cs
Outdated
Show resolved
Hide resolved
I suggest to convert this PR to draft while it's work in progress. Otherwise this will keep notifying people. https://github.blog/2019-02-14-introducing-draft-pull-requests/ . I also suggest to review the design before implementing this. |
@kasobol-msft Thanks - changed back to draft. What in particular are you referring to in terms of design? |
For design, I suggest to start internal email thread with me, @fabiocav and @paulbatum . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the context provided offline. This helped a lot to understand this PR.
Could you please update description of this PR to reference related work?
Could you also provide a short write up explaining the change for other reviewers?
...orage/Microsoft.Azure.WebJobs.Extensions.Storage.Blobs/src/Bindings/CacheAfterWriteStream.cs
Outdated
Show resolved
Hide resolved
...orage/Microsoft.Azure.WebJobs.Extensions.Storage.Blobs/src/Bindings/CacheAfterWriteStream.cs
Outdated
Show resolved
Hide resolved
...orage/Microsoft.Azure.WebJobs.Extensions.Storage.Blobs/src/Bindings/CacheAfterWriteStream.cs
Outdated
Show resolved
Hide resolved
.../Microsoft.Azure.WebJobs.Extensions.Storage.Blobs/src/Config/BlobsExtensionConfigProvider.cs
Outdated
Show resolved
Hide resolved
.../Microsoft.Azure.WebJobs.Extensions.Storage.Blobs/src/Config/BlobsExtensionConfigProvider.cs
Outdated
Show resolved
Hide resolved
sdk/storage/Microsoft.Azure.WebJobs.Extensions.Storage.Blobs/src/ReadBlobArgumentBinding.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Please add test coverage and clean up changes in csproj and .Config files.
...ge/Microsoft.Azure.WebJobs.Extensions.Storage.Blobs/src/Bindings/CacheObjectAndBlobStream.cs
Outdated
Show resolved
Hide resolved
sdk/storage/Microsoft.Azure.WebJobs.Extensions.Storage.Blobs/src/ReadBlobArgumentBinding.cs
Outdated
Show resolved
Hide resolved
@kasobol-msft Ready for your final pass. This PR will still have to wait for the WebJobs SDK changes to go in though since that's where the new interfaces are defined. |
…ilable to be injected; perform cache-aware binding where applicable
… published on nuget
5551a23
to
2d02ae5
Compare
Context
This PR is part of the work described in Azure/azure-functions-host#7310
All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
Draft
mode if it is:General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
*.csproj
andAssemblyInfo.cs
files have been updated with the new version of the SDK. Please double check nuget.org current release version.Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP]
orAzure.ResourceManager.[RP]
Management plane SDK Troubleshooting
If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add
new service
label and/or contact assigned reviewer.If the check fails at the
Verify Code Generation
step, please ensure:generate.ps1/cmd
to generate this PR instead of callingautorest
directly.Please pay attention to the @microsoft.csharp version output after running
generate.ps1
. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.Note: We have recently updated the PSH module called by
generate.ps1
to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.