Migrate keyvault to pipeline #962
Conversation
| )); | ||
| let creds = Arc::new( | ||
| DefaultAzureCredentialBuilder::new() | ||
| .exclude_managed_identity_credential() |
There was a problem hiding this comment.
If this is always excluded in our examples, should we perhaps think about inverting this and requiring users who want it, to opt into it?
| @@ -54,63 +58,51 @@ impl KeyvaultClient { | |||
| ) -> azure_core::Result<Self> { | |||
| let vault_url = Url::parse(vault_url)?; | |||
There was a problem hiding this comment.
Can we eventually adopt something like azure_data_cosmos::CloudLocation instead of dealing in raw URLs?
| scope: String, | ||
| ) -> Pipeline { | ||
| let auth_policy: Arc<dyn azure_core::Policy> = | ||
| Arc::new(AuthorizationPolicy::new(credentials, scope)); |
There was a problem hiding this comment.
In cosmos we're sending the equivalent of scope as part of the Context. Would that perhaps work better here too?
|
@bmc-msft this looks good! I known there's still lots of improvements that we could make, but it seems like it would be a good idea to land this and then do some follow up PRs. What do you think? |
|
Yeah, I'm happy to do that. It will take some refactoring to enable client builders to enable alternate transports, which is needed for doing the mocking. |
No description provided.