ci: fix clippy lints and a couple other small things #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reads MSRV from clippy.toml rather than hardcoding it; uses nightly compiler for clippy runs; adds cronjob to update nightly compiler pin.
Mostly they are complaining about the new "format specifiers can directly hold the variable, if that variable is a single token, and if the format specifier is in println or format but not write or assert, so you should convert 40% of your instances to this different format, because it makes a big diff and leaves your code in an unreadable state" lint, which personally I don't feel is a net benefit. Copy the whole list of whitelisted clippy lints from rust-elements.
There is a huge list of lints I'd like to enable (currently in rust-elements and a few other crates). As a start, enable the cast_lossless one, which I think is very important: it complaints if you use a cast where usize::from() would suffice. The benefit of the from() syntax is that it will compile iff the cast cannot truncate. So the reader of the code can tell immediately that there is no danger of changing the value, and if the lint is on, conversely the reader can tell that anything that *is* a cast is something that needs further scrutiny.
|
cc @canndrew can you review this one as well (and this one won't get auto-pushed in a breaking way :P) |
|
ACK 48634a8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nightly-versionversion of clippy so that we won't break as new lints come out