A bug occurs on update

[asmsuechan]

Hi, I hit a bug on update...

Does anyone arise it?

After I had killed Boostnote process and restarted, it was updated properly (v0.8.2).

[kazup01]

We are investigating the cause of this bug.
Downloading the latest version from the official page(http://boostnote.io/#download) again will work fine, so I recommend it.
Of course the data are not deleted, it is possible to take over without problems.

[sota1235]

Thank you for reporting.
What is the version you used? Please tell me 🙇

[asmsuechan]

It occurs on update from v0.8.1 to v0.8.2. Possibly, my commits are related with it.

[sota1235]

I see. I try to investigate...!

[asmsuechan]

I blamed the line of the bug, I recognize it is my fault 😨
https://github.com/BoostIO/Boostnote/blob/master/lib/main-window.js#L52

Perhaps if (app) or if (mainWindow) is necessary. However I'm not sure it's really a correct way to fix because I have no means to test/reappearance the bug.

refs: http://stackoverflow.com/questions/38309240/object-has-been-destroyed-when-open-secondary-child-window-in-electron-js
jprichardson/electron-window#5 (reference)

[asmsuechan]

electron-gh-releases is used on update (https://github.com/BoostIO/Boostnote/blob/master/lib/main-app.js#L79)

And install() method uses quitAndInstall(). According to the reference of quitAndInstall() (here),

Note: autoUpdater.quitAndInstall() will close all application windows first and only emit before-quit event on app after that. This is different from the normal quit event sequence.

The bug occurs at before-quit event. Thus it's related with the bug.

[asmsuechan]

I created quit event like below though same error still occurs.

  app.on('quit', function (e) {
    config.set('windowsize', mainWindow.getBounds())
  })

[sota1235]

Great fixing by @asmsuechan !!
It will be released on v0.8.3

[kazup01]

Thank you for your help, @asmsuechan !👏

[sota1235]

It's fixed on v0.8.3. Thank you for reporting!