Skip to content

Fixes #1723 #1724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2018
Merged

Fixes #1723 #1724

merged 2 commits into from
Apr 10, 2018

Conversation

ehhc
Copy link
Contributor

@ehhc ehhc commented Mar 22, 2018

Attached to this issue is a very quick-and-dirty solution for the given problem. Alas I still do have a lot of questions, I can’t figure out (resp. a lot of issues I stumbled over):

  1. The html export of notes containing images is broken -> no images present
  2. Markdown export with embed files/images is broken -> links are broke
  3. Why are the dropped files named with Math.random().toString(36).slice(-16) (CopyImages.js) instead of something more resilient like Hash(Timestamp + filename) ? Math.random() might return the same result again. Especially when not properly initialized!
  4. Why are there (at various places) different definitions of markdown-templates to include images? I’ve found at least 3 without being able to figure out why they aren’t at one central place and in what cases they are used
  5. Why are there multiple definitions of the image folder path? e.g. moveNote.js:77, exportNote.js:9, copyImage.js:22 and none global definition? A global reliable definition of this constant variable is missing
  6. No documentation (e.g. JavaScript Doc) is provided. You have to guess what a method does and why it is necessary

Further issues coming up with my dirty fix hack:

  • methods aren’t doing what they promise to do: e.g. copyImage is able to and use for copying abbreviated files.
  • “Images” folder (see 5) ) contains further non images attachments as well

I hope you can understand my surprise/irritation about these various issues..

@Rokt33r Rokt33r added the awaiting review ❇️ Pull request is awaiting a review. label Mar 23, 2018
@Rokt33r Rokt33r merged commit 6142f2d into BoostIO:master Apr 10, 2018
@Rokt33r Rokt33r added next release (v0.12.0) and removed awaiting review ❇️ Pull request is awaiting a review. labels Apr 10, 2018
@ehhc ehhc deleted the Issue_1723 branch April 15, 2018 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants