Fix incorrect tag completion in code block #341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmsuechan
changed the title
asmsuechan
changed the title
|
Until the second commit, KaTeX didn't work well. But now after third commit, it works well.
|
asmsuechan
commented
Mar 27, 2017
| @@ -14,7 +14,8 @@ function decodeHTMLEntities (text) { | |||
| ['apos', '\''], | |||
| ['amp', '&'], | |||
| ['lt', '<'], | |||
| ['gt', '>'] | |||
| ['gt', '>'], | |||
| ['#63', '?'] | |||
| ] | |||
|
|
|||
| for (var i = 0, max = entities.length; i < max; ++i) { | |||
There was a problem hiding this comment.
This for loop must be refactored.
This was referenced Apr 17, 2017
sota1235
suggested changes
Apr 22, 2017
because when & is encoded, it affect other encodes due to they use &
|
I fixed that bug, cut into a helper, and also added tests.
|
sota1235
reviewed
Apr 29, 2017
| const decodedText = htmlTextHelper.decodeEntities(encodedText) | ||
| t.is(decodedText, testCase, 'Integration test through encodedText() and decodedText()') | ||
| }) | ||
| }) |
There was a problem hiding this comment.
You are good JavaScript Engineer 👍
|
o~ |
|
fantastic👍 |
Merged
|
I'm running 0.11.12 and get this issue again. Is there an option checkbox I need to tick or has the fix been broken with later updates? EDIT: Noticed it only happen when enabling dangerous HTML tags. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally, I fixed this problem which is reported by #333 and #294.
Before, this code didn't work well in CodeBlock:
<port protcol="tcp" port="10022"/>before
after