Skip to content

Fix text on menu bar(macOS) and some refactor #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 22, 2017
Merged

Fix text on menu bar(macOS) and some refactor #468

merged 3 commits into from
Apr 22, 2017

Conversation

sota1235
Copy link
Contributor

Before

image

After

image

Please check

  • Is it working?
  • Is there any problem for existing features?

@sota1235 sota1235 self-assigned this Apr 22, 2017
sosukesuzuki
sosukesuzuki approved these changes Apr 22, 2017
View reviewed changes
Copy link
Member

@sosukesuzuki sosukesuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can been worked, and I think that your code has no problems.

@sota1235
Copy link
Contributor Author

Thanks 💪

@sota1235 sota1235 merged commit cfeeba2 into master Apr 22, 2017
@sota1235 sota1235 deleted the feature-fix-text branch April 22, 2017 07:32
@sota1235 sota1235 mentioned this pull request Apr 22, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sosukesuzuki sosukesuzuki sosukesuzuki approved these changes

@kohei-takata kohei-takata Awaiting requested review from kohei-takata

@asmsuechan asmsuechan Awaiting requested review from asmsuechan

Assignees

@sota1235 sota1235

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sota1235 @sosukesuzuki