[ENG-8064] Add New Notifications Data Model (Refactor Notifications Phase 2) #11151

Johnetordoff · 2025-05-20T14:09:45Z

Purpose

This is Phase 2 of the Notifications Refactor it creates a new notification system and migrates the existing data into that model.

Changes

A slight change to handle_boa_error to pass the already decanted user object.
adds new data model for Notification, NotificationTypes and Subscriptions
creates a notifications.yaml for data dependency notificationtypes
add migrations
updates notifications to use NotificationTypes
updates Admin app to control email templates
updates metrics reporter to count notifications sent etc.
updates tests to all use capture_notifications mocking util
Removes queued_mail
Removes EmailDigest
Removes detect_duplicates for duplicate subscriptions

QA Notes

Please make verification statements inspired by your code and what your code touches.

Verify
Verify

What are the areas of risk?

Any concerns/considerations/questions that development raised?

Documentation

Side Effects

Ticket

https://openscience.atlassian.net/browse/ENG-8064

…cience/osf.io into add-new-notifications-data-model * 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io: [ENG-7965] Add v2 email token confirmation endpoints (CenterForOpenScience#11139)

…cience/osf.io into add-new-notifications-data-model * 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io: fix issue where not having any external identities caused a 500

…cience/osf.io into add-new-notifications-data-model * 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io: [ENG-7966] Add "collected-in" relationship for Nodes (CenterForOpenScience#11140)

…cience/osf.io into add-new-notifications-data-model * 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io: fix issue where trying another already confirmed email threw an uncaught exception (CenterForOpenScience#11161) [ENG-8148] Add ArtifactOutcome in annotations to linked nodes (CenterForOpenScience#11158)

…OpenScience/osf.io into add-new-notifications-data-model * 'refactor-notifications' of https://github.com/CenterForOpenScience/osf.io: flake8 fixed tests remove quickfiles update mails mock Update send_mail mocks Clean up tests Clean up tests Clean up imports Remove Meetings, Comments and OSF Groups Notifications remove osf groups remove osf groups remove osf groups remove osf groups remove osf groups # Conflicts: # tests/test_notifications.py

…cience/osf.io into add-new-notifications-data-model * 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io: Update hybrid values for new workflow check (CenterForOpenScience#11166)

…OpenScience/osf.io into add-new-notifications-data-model * 'refactor-notifications' of https://github.com/CenterForOpenScience/osf.io: ignore Django maintenance state outside block

…OpenScience/osf.io into add-new-notifications-data-model * 'refactor-notifications' of https://github.com/CenterForOpenScience/osf.io: fixed bug with contributors remove superfluildous `groups` from serializer fix new and noteworth nodes bug going to Sentry

…cience/osf.io into add-new-notifications-data-model * 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io: fixed None issue when iterate (CenterForOpenScience#11192) [ENG-8048] Remove caching to avoid incorrect results for ascendants (CenterForOpenScience#11169) [ENG-7870] Crossref DOIs not minting with _v1, OSF is displaying DOI versions with _v1 (CenterForOpenScience#11154) Update changelog and package.json [ENG-8145] [ENG-8147] Manual DOI and GUID for Preprints & Registrations - BE (CenterForOpenScience#11174)

…cience/osf.io into add-new-notifications-data-model * 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io: Revert "[ENG-8048] Remove caching to avoid incorrect results for ascendants (…" Revert "fixed None issue when iterate (CenterForOpenScience#11192)"

…OpenScience/osf.io into add-new-notifications-data-model * 'refactor-notifications' of https://github.com/CenterForOpenScience/osf.io:

into add-new-notifications-data-model * 'develop' of https://github.com/CenterForOpenScience/osf.io: Bump version no. Add CHANGELOG move CROSSREF_UNAVAILABLE_DELAY to settings.py handle and 5xx status code from crossref handle 500 error from crossref Update changelog and package.json

Johnetordoff · 2025-07-31T13:10:04Z

addons/boa/tasks.py

    )
    return BoaErrorCode.NO_ERROR


-def handle_boa_error(message, code, username, fullname, project_url, query_file_full_path,


A slight change to handle_boa_error to pass the already decanted user object. Need user object for subscription

Johnetordoff · 2025-07-31T13:11:13Z

admin/nodes/views.py

@@ -101,13 +101,10 @@ def get_context_data(self, **kwargs):
        context = super().get_context_data(**kwargs)
        node = self.get_object()

-        detailed_duplicates = detect_duplicate_notifications(node_id=node.id)


Can't have duplicate subscriptions, so no reason to detect,

Johnetordoff · 2025-07-31T13:14:12Z

api/nodes/serializers.py

@@ -1206,7 +1206,7 @@ def get_unregistered_contributor(self, obj):
            return unclaimed_records.get('name', None)


-class NodeContributorsCreateSerializer(NodeContributorsSerializer):
+class ResourceContributorsCreateSerializer(NodeContributorsSerializer):


Refactor for better name

Johnetordoff force-pushed the add-new-notifications-data-model branch 3 times, most recently from ecc8e88 to 3a8b414 Compare May 21, 2025 14:28

add new data model for notifications

57b0bd1

Johnetordoff force-pushed the add-new-notifications-data-model branch from 3a8b414 to 57b0bd1 Compare May 21, 2025 14:42

Johnetordoff added 8 commits May 22, 2025 09:39

add new notificationsubscription class to views

69231e9

Johnetordoff force-pushed the add-new-notifications-data-model branch from 2b8ba0d to c449599 Compare June 9, 2025 13:40

Johnetordoff changed the base branch from feature/pbs-25-10 to refactor-notifications June 13, 2025 14:40

Johnetordoff added 5 commits June 16, 2025 10:46

fix absolute url issue

f550c61

fix up unit test issues

458fbfd

Merge branch 'refactor-notifications' of https://github.com/CenterFor…

bb145f4

…OpenScience/osf.io into add-new-notifications-data-model * 'refactor-notifications' of https://github.com/CenterForOpenScience/osf.io:

Johnetordoff force-pushed the add-new-notifications-data-model branch 2 times, most recently from dfe88a2 to ad18e9d Compare July 3, 2025 13:48

fix backward compat issues and remove old tests

300524c

Johnetordoff force-pushed the add-new-notifications-data-model branch from ad18e9d to 300524c Compare July 3, 2025 14:20

Johnetordoff added 4 commits July 7, 2025 10:27

split notification models into 3 files and improve interval choices

85e1342

clean-up tests and pass frequency data properly

f2e5309

update management commands and tests for notification migration

0471b76

Johnetordoff marked this pull request as ready for review July 8, 2025 20:05

Johnetordoff force-pushed the add-new-notifications-data-model branch 4 times, most recently from 8fb240f to 124655c Compare July 30, 2025 23:44

remove mails and copy over subject lines

51df115

Johnetordoff force-pushed the add-new-notifications-data-model branch 5 times, most recently from 0ef60ab to e6ebf4b Compare July 31, 2025 02:13

remove old comment based notification tests

5ec04a0

Johnetordoff force-pushed the add-new-notifications-data-model branch from e6ebf4b to 774ede0 Compare July 31, 2025 02:58

remove mails.py

f281e99

Johnetordoff force-pushed the add-new-notifications-data-model branch from 774ede0 to f281e99 Compare July 31, 2025 03:02

Johnetordoff added 4 commits July 30, 2025 23:22

fixing mailhog tests to use Django mail BE

dbf4815

more mails removal

ebffbe4

fix send grid code

795a7e6

fix more sanctions code

a90a234

Johnetordoff force-pushed the add-new-notifications-data-model branch from 1122a3e to a90a234 Compare July 31, 2025 04:16

Johnetordoff added 2 commits July 31, 2025 07:34

fix more schema responses

8421403

fix boa

f9d4249

Johnetordoff commented Jul 31, 2025

View reviewed changes

Johnetordoff added 2 commits July 31, 2025 09:15

fix mock user

4c2d145

fix schema response tests

7ccc8fb

Johnetordoff force-pushed the add-new-notifications-data-model branch from 857b129 to 7ccc8fb Compare July 31, 2025 14:19

fix insti reporter tests

c418021

Johnetordoff changed the title ~~[ENG-8064] Add New Notifications Data Model~~ [ENG-8064] Add New Notifications Data Model (Refactor Notifications Phase 2) Jul 31, 2025

clean resource contributors create method

57ba198

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[ENG-8064] Add New Notifications Data Model (Refactor Notifications Phase 2) #11151

[ENG-8064] Add New Notifications Data Model (Refactor Notifications Phase 2) #11151

Uh oh!

Johnetordoff commented May 20, 2025 •

edited

Loading

Uh oh!

Johnetordoff Jul 31, 2025

Uh oh!

Johnetordoff Jul 31, 2025

Uh oh!

Johnetordoff Jul 31, 2025

Uh oh!

Uh oh!

[ENG-8064] Add New Notifications Data Model (Refactor Notifications Phase 2) #11151

Are you sure you want to change the base?

[ENG-8064] Add New Notifications Data Model (Refactor Notifications Phase 2) #11151

Uh oh!

Conversation

Johnetordoff commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose

Changes

QA Notes

Documentation

Side Effects

Ticket

Uh oh!

Johnetordoff Jul 31, 2025

Choose a reason for hiding this comment

Uh oh!

Johnetordoff Jul 31, 2025

Choose a reason for hiding this comment

Uh oh!

Johnetordoff Jul 31, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Johnetordoff commented May 20, 2025 •

edited

Loading