Add platform and locale-aware desktop guide URL #4471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Full test here Google.Chrome.mp4 |
christian-byrne
added a commit
that referenced
this pull request
Jul 18, 2025
- Create src/constants/urls.ts with centralized URL constants (COMFY_URLS, GITHUB_REPOS, MODEL_SOURCES, DEVELOPER_TOOLS) - Move runtime domain config to src/config/comfyDomain.ts to allow forkers to customize via env var - Rename uvMirrors.ts to mirrors.ts for better naming consistency - Add platform and locale-aware desktop guide URL generation (matching PR #4471) - Update 10 components to use centralized URL constants - Add comprehensive unit and e2e tests for URL constants validation This refactoring improves maintainability by centralizing 150+ hardcoded URLs found across 50+ files into a single organized structure.
christian-byrne
added a commit
that referenced
this pull request
Jul 18, 2025
- Create src/constants/urls.ts with centralized URL constants (COMFY_URLS, GITHUB_REPOS, MODEL_SOURCES, DEVELOPER_TOOLS) - Move runtime domain config to src/config/comfyDomain.ts to allow forkers to customize via env var - Rename uvMirrors.ts to mirrors.ts for better naming consistency - Add platform and locale-aware desktop guide URL generation (matching PR #4471) - Update 10 components to use centralized URL constants - Add comprehensive unit and e2e tests for URL constants validation This refactoring improves maintainability by centralizing 150+ hardcoded URLs found across 50+ files into a single organized structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the desktop guide links to make them platform and locale-aware
┆Issue is synchronized with this Notion page by Unito