-
Notifications
You must be signed in to change notification settings - Fork 1.3k
fix(otel/metrics): add otel.
prefix to host and some kafka metrics in the Converged Agent
#28228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
otel.
prefix to host and some kafka metrics
122ede1
to
a66cda4
Compare
a66cda4
to
d364cd9
Compare
406f5db
to
7a7f8d6
Compare
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=41254375 --os-family=ubuntu Note: This applies to commit 90dfa98 |
Regression DetectorRegression Detector ResultsRun ID: fe7e9b10-179c-4312-b68f-cc8d5e36377f Metrics dashboard Target profiles Baseline: 1a835ad Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI | links |
---|---|---|---|---|---|
➖ | otel_to_otel_logs | ingress throughput | +0.59 | [-0.22, +1.41] | Logs |
➖ | idle | memory utilization | +0.29 | [+0.25, +0.32] | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.00, +0.00] | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | Logs |
➖ | basic_py_check | % cpu utilization | -0.92 | [-3.60, +1.77] | Logs |
➖ | file_tree | memory utilization | -1.21 | [-1.30, -1.13] | Logs |
➖ | pycheck_1000_100byte_tags | % cpu utilization | -1.25 | [-5.99, +3.50] | Logs |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -2.23 | [-3.10, -1.35] | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | -6.59 | [-18.98, +5.80] | Logs |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you do a quick sanity check from your branch to see if this works e2e?
inv otel-agent.build
cd bin/otel-agent
./otel-agent --config config.yaml
- Go to DD and verify host metrics are sent with
otel.
prefix. E.g.otel.system.cpu.load_average.15m
Use this as config.yaml :
receivers:
hostmetrics:
scrapers:
load:
memory:
exporters:
datadog:
api:
key: ${env:DD_API_KEY}
service:
pipelines:
metrics/sys:
receivers: [hostmetrics]
exporters: [datadog]
releasenotes/notes/munir-add-with-otel-prefix-covagent-f4650caf7d2fcab7.yaml
Outdated
Show resolved
Hide resolved
cc @dineshg13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
otel.
prefix to host and some kafka metrics otel.
prefix to host and some kafka metrics in tjr covagent
otel.
prefix to host and some kafka metrics in tjr covagentotel.
prefix to host and some kafka metrics in the coveraged agent
otel.
prefix to host and some kafka metrics in the coveraged agentotel.
prefix to host and some kafka metrics in the Converged Agent
Looks like you need |
/merge |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
What does this PR do?
Updates
opentelemetry-mappings-go
metrics configurations to include theWithOTelPrefix
option. This option will appendotel.
prefix to allsystem.*
,proccess.*
, and a subet ofkafka.*
metrics received via OTLP.Motivation
This change will resolve conflicts between opentelemetry and datadog metrics names.
Additional Notes
The converged agent is unreleased. This change does not require a release note.
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes